Re: [PATCH 16/22] ncr5380: Fix register decoding for debugging

2016-03-14 Thread Finn Thain
On Mon, 14 Mar 2016, Hannes Reinecke wrote: > Well ... using individual printk() like here might end up in each > call to be broken up into individual lines. > You might want to consider using a line buffer here or, better > still, move to seq_file or debugfs output. This routine is meant to be

Re: [PATCH 16/22] ncr5380: Fix register decoding for debugging

2016-03-14 Thread Finn Thain
On Mon, 14 Mar 2016, Hannes Reinecke wrote: > Well ... using individual printk() like here might end up in each > call to be broken up into individual lines. > You might want to consider using a line buffer here or, better > still, move to seq_file or debugfs output. This routine is meant to be

Re: [PATCH 16/22] ncr5380: Fix register decoding for debugging

2016-03-14 Thread Hannes Reinecke
On 03/14/2016 05:27 AM, Finn Thain wrote: > Decode all bits in the chip registers. They are all useful at times. > Fix printk severity so that this output can be suppressed along with > the other debugging output. > > Signed-off-by: Finn Thain > > --- >

Re: [PATCH 16/22] ncr5380: Fix register decoding for debugging

2016-03-14 Thread Hannes Reinecke
On 03/14/2016 05:27 AM, Finn Thain wrote: > Decode all bits in the chip registers. They are all useful at times. > Fix printk severity so that this output can be suppressed along with > the other debugging output. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 42

[PATCH 16/22] ncr5380: Fix register decoding for debugging

2016-03-13 Thread Finn Thain
Decode all bits in the chip registers. They are all useful at times. Fix printk severity so that this output can be suppressed along with the other debugging output. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 42

[PATCH 16/22] ncr5380: Fix register decoding for debugging

2016-03-13 Thread Finn Thain
Decode all bits in the chip registers. They are all useful at times. Fix printk severity so that this output can be suppressed along with the other debugging output. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 42 +- 1 file changed, 25