Re: [PATCH 16/23] initramfs: simplify clean_rootfs

2020-07-26 Thread Matthew Wilcox
On Mon, Jul 27, 2020 at 03:41:49AM +0100, Al Viro wrote: > On Thu, Jul 23, 2020 at 04:27:34PM +0200, Christoph Hellwig wrote: > > On Thu, Jul 23, 2020 at 04:25:34PM +0200, Lukasz Stelmach wrote: > > > >> Can you comment out the call to d_genocide? It seems like for your > > > >> the fact that clea

Re: [PATCH 16/23] initramfs: simplify clean_rootfs

2020-07-26 Thread Al Viro
On Thu, Jul 23, 2020 at 04:27:34PM +0200, Christoph Hellwig wrote: > On Thu, Jul 23, 2020 at 04:25:34PM +0200, Lukasz Stelmach wrote: > > >> Can you comment out the call to d_genocide? It seems like for your > > >> the fact that clean_rootfs didn't actually clean up was a feature and > > >> not a

Re: [PATCH 16/23] initramfs: simplify clean_rootfs

2020-07-23 Thread Christoph Hellwig
On Thu, Jul 23, 2020 at 04:25:34PM +0200, Lukasz Stelmach wrote: > >> Can you comment out the call to d_genocide? It seems like for your > >> the fact that clean_rootfs didn't actually clean up was a feature and > >> not a bug. > >> > >> I guess the old, pre-2008 code also wouldn't have worked fo

Re: [PATCH 16/23] initramfs: simplify clean_rootfs

2020-07-23 Thread Lukasz Stelmach
It was <2020-07-23 czw 11:22>, when Christoph Hellwig wrote: > On Sat, Jul 18, 2020 at 12:00:35PM +0200, Christoph Hellwig wrote: >> On Fri, Jul 17, 2020 at 10:55:48PM +0200, Marek Szyprowski wrote: >>> On 14.07.2020 21:04, Christoph Hellwig wrote: Just use d_genocide instead of iterating thro

Re: [PATCH 16/23] initramfs: simplify clean_rootfs

2020-07-23 Thread Christoph Hellwig
On Sat, Jul 18, 2020 at 12:00:35PM +0200, Christoph Hellwig wrote: > On Fri, Jul 17, 2020 at 10:55:48PM +0200, Marek Szyprowski wrote: > > Hi Christoph, > > > > On 14.07.2020 21:04, Christoph Hellwig wrote: > > > Just use d_genocide instead of iterating through the root directory with > > > cumber

Re: [PATCH 16/23] initramfs: simplify clean_rootfs

2020-07-18 Thread Christoph Hellwig
On Fri, Jul 17, 2020 at 10:55:48PM +0200, Marek Szyprowski wrote: > Hi Christoph, > > On 14.07.2020 21:04, Christoph Hellwig wrote: > > Just use d_genocide instead of iterating through the root directory with > > cumbersome userspace-like APIs. This also ensures we actually remove files > > that

Re: [PATCH 16/23] initramfs: simplify clean_rootfs

2020-07-17 Thread Marek Szyprowski
Hi Christoph, On 14.07.2020 21:04, Christoph Hellwig wrote: > Just use d_genocide instead of iterating through the root directory with > cumbersome userspace-like APIs. This also ensures we actually remove files > that are not direct children of the root entry, which the old code failed > to do.

[PATCH 16/23] initramfs: simplify clean_rootfs

2020-07-14 Thread Christoph Hellwig
Just use d_genocide instead of iterating through the root directory with cumbersome userspace-like APIs. This also ensures we actually remove files that are not direct children of the root entry, which the old code failed to do. Fixes: df52092f3c97 ("fastboot: remove duplicate unpack_to_rootfs()"