Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter

2020-07-03 Thread Joe Perches
On Fri, 2020-07-03 at 11:35 +0200, Miguel Ojeda wrote: > On Fri, Jul 3, 2020 at 9:44 AM Joe Perches wrote: > > And I'd generally not bother with 80 column rewrapping > > Thanks for the quick answer Joe -- here I was referring to the cases > where one needs to move all the `=`s to the right like:

Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter

2020-07-03 Thread Miguel Ojeda
On Fri, Jul 3, 2020 at 9:44 AM Joe Perches wrote: > > And I'd generally not bother with 80 column rewrapping Thanks for the quick answer Joe -- here I was referring to the cases where one needs to move all the `=`s to the right like: static const struct file_operations memtype_fops = { .open

Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter

2020-07-03 Thread Joe Perches
On Fri, 2020-07-03 at 07:56 +0200, Miguel Ojeda wrote: > On Thu, Jul 2, 2020 at 3:50 PM Christoph Hellwig wrote: > > Do you have a suggestion for an automated replacement which does? > > I'll happily switch over to that. > > I guess I'd simply find the unique set of cases that occur and create >

Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter

2020-07-02 Thread Miguel Ojeda
On Thu, Jul 2, 2020 at 3:50 PM Christoph Hellwig wrote: > > Do you have a suggestion for an automated replacement which does? > I'll happily switch over to that. I guess I'd simply find the unique set of cases that occur and create a replacement for each manually. A handful of them or so may

Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter

2020-07-02 Thread Christoph Hellwig
On Thu, Jul 02, 2020 at 11:46:17AM +0200, Miguel Ojeda wrote: > Hi Christoph, > > On Wed, Jul 1, 2020 at 10:25 PM Christoph Hellwig wrote: > > > > Switch over all instances used directly as methods using these sed > > expressions: > > > > sed -i -e

Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter

2020-07-02 Thread Miguel Ojeda
Hi Christoph, On Wed, Jul 1, 2020 at 10:25 PM Christoph Hellwig wrote: > > Switch over all instances used directly as methods using these sed > expressions: > > sed -i -e 's/\.read\(\s*=\s*\)seq_read/\.read_iter\1seq_read_iter/g' > > Signed-off-by: Christoph Hellwig Nit: the replacements don't