Re: [PATCH 16/32] staging: gasket: always allow root open for write

2018-07-19 Thread Todd Poynor
On Thu, Jul 19, 2018 at 2:29 AM, Greg Kroah-Hartman wrote: > On Tue, Jul 17, 2018 at 01:56:56PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Always allow root to open device for writing. >> >> Drop special-casing of ioctl permissions for root vs. owner. >> >> Reported-by: Dmitry Torokhov

Re: [PATCH 16/32] staging: gasket: always allow root open for write

2018-07-19 Thread Todd Poynor
On Thu, Jul 19, 2018 at 2:29 AM, Greg Kroah-Hartman wrote: > On Tue, Jul 17, 2018 at 01:56:56PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Always allow root to open device for writing. >> >> Drop special-casing of ioctl permissions for root vs. owner. >> >> Reported-by: Dmitry Torokhov

Re: [PATCH 16/32] staging: gasket: always allow root open for write

2018-07-19 Thread Greg Kroah-Hartman
On Tue, Jul 17, 2018 at 01:56:56PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Always allow root to open device for writing. > > Drop special-casing of ioctl permissions for root vs. owner. > > Reported-by: Dmitry Torokhov > Signed-off-by: Zhongze Hu > Signed-off-by: Todd Poynor > ---

Re: [PATCH 16/32] staging: gasket: always allow root open for write

2018-07-19 Thread Greg Kroah-Hartman
On Tue, Jul 17, 2018 at 01:56:56PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Always allow root to open device for writing. > > Drop special-casing of ioctl permissions for root vs. owner. > > Reported-by: Dmitry Torokhov > Signed-off-by: Zhongze Hu > Signed-off-by: Todd Poynor > ---

[PATCH 16/32] staging: gasket: always allow root open for write

2018-07-17 Thread Todd Poynor
From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 9 +

[PATCH 16/32] staging: gasket: always allow root open for write

2018-07-17 Thread Todd Poynor
From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 9 +

Re: [PATCH 16/32] staging: gasket: always allow root open for write

2018-07-17 Thread Todd Poynor
On Tue, Jul 17, 2018 at 11:50 AM, Joe Perches wrote: > On Tue, 2018-07-17 at 13:22 +0300, Dan Carpenter wrote: >> On Mon, Jul 16, 2018 at 07:09:10PM -0700, Todd Poynor wrote: >> > --- a/drivers/staging/gasket/apex_driver.c >> > +++ b/drivers/staging/gasket/apex_driver.c >> > @@ -630,13 +630,10 @@

Re: [PATCH 16/32] staging: gasket: always allow root open for write

2018-07-17 Thread Todd Poynor
On Tue, Jul 17, 2018 at 11:50 AM, Joe Perches wrote: > On Tue, 2018-07-17 at 13:22 +0300, Dan Carpenter wrote: >> On Mon, Jul 16, 2018 at 07:09:10PM -0700, Todd Poynor wrote: >> > --- a/drivers/staging/gasket/apex_driver.c >> > +++ b/drivers/staging/gasket/apex_driver.c >> > @@ -630,13 +630,10 @@

Re: [PATCH 16/32] staging: gasket: always allow root open for write

2018-07-17 Thread Joe Perches
On Tue, 2018-07-17 at 13:22 +0300, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:10PM -0700, Todd Poynor wrote: > > --- a/drivers/staging/gasket/apex_driver.c > > +++ b/drivers/staging/gasket/apex_driver.c > > @@ -630,13 +630,10 @@ static bool is_gcb_in_reset(struct gasket_dev > >

Re: [PATCH 16/32] staging: gasket: always allow root open for write

2018-07-17 Thread Joe Perches
On Tue, 2018-07-17 at 13:22 +0300, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:10PM -0700, Todd Poynor wrote: > > --- a/drivers/staging/gasket/apex_driver.c > > +++ b/drivers/staging/gasket/apex_driver.c > > @@ -630,13 +630,10 @@ static bool is_gcb_in_reset(struct gasket_dev > >

Re: [PATCH 16/32] staging: gasket: always allow root open for write

2018-07-17 Thread Dan Carpenter
On Mon, Jul 16, 2018 at 07:09:10PM -0700, Todd Poynor wrote: > --- a/drivers/staging/gasket/apex_driver.c > +++ b/drivers/staging/gasket/apex_driver.c > @@ -630,13 +630,10 @@ static bool is_gcb_in_reset(struct gasket_dev > *gasket_dev) > static uint apex_ioctl_check_permissions(struct file

Re: [PATCH 16/32] staging: gasket: always allow root open for write

2018-07-17 Thread Dan Carpenter
On Mon, Jul 16, 2018 at 07:09:10PM -0700, Todd Poynor wrote: > --- a/drivers/staging/gasket/apex_driver.c > +++ b/drivers/staging/gasket/apex_driver.c > @@ -630,13 +630,10 @@ static bool is_gcb_in_reset(struct gasket_dev > *gasket_dev) > static uint apex_ioctl_check_permissions(struct file

[PATCH 16/32] staging: gasket: always allow root open for write

2018-07-16 Thread Todd Poynor
From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor Reviewed-by: Dmitry Torokhov --- drivers/staging/gasket/apex_driver.c | 9

[PATCH 16/32] staging: gasket: always allow root open for write

2018-07-16 Thread Todd Poynor
From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor Reviewed-by: Dmitry Torokhov --- drivers/staging/gasket/apex_driver.c | 9