Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev

2019-04-02 Thread Linus Walleij
On Tue, Mar 12, 2019 at 1:55 AM Enrico Weigelt, metux IT consult wrote: > don't need the temporary variable "dev", directly use &pdev->dev > > Signed-off-by: Enrico Weigelt, metux IT consult Dropping this patch following the discussion. I like it better as it is :D Yours, Linus Walleij

Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev

2019-03-12 Thread Enrico Weigelt, metux IT consult
On 12.03.19 12:26, Thierry Reding wrote: > You're not consistent within the series itself. In patch 3 you went the > other way and dropped usage of pdev->dev in favour of the local dev > variable. ups, you got me :O -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineerin

Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev

2019-03-12 Thread Thierry Reding
On Tue, Mar 12, 2019 at 10:33:44AM +0100, Enrico Weigelt, metux IT consult wrote: > On 12.03.19 10:17, Ben Dooks wrote: > > On 11/03/2019 18:54, Enrico Weigelt, metux IT consult wrote: > >> don't need the temporary variable "dev", directly use &pdev->dev > >> > >> Signed-off-by: Enrico Weigelt, me

Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev

2019-03-12 Thread Enrico Weigelt, metux IT consult
On 12.03.19 10:17, Ben Dooks wrote: > On 11/03/2019 18:54, Enrico Weigelt, metux IT consult wrote: >> don't need the temporary variable "dev", directly use &pdev->dev >> >> Signed-off-by: Enrico Weigelt, metux IT consult > > This is quite usual to do, and I like it as it saves typing. > Personall

Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev

2019-03-12 Thread Ben Dooks
On 11/03/2019 18:54, Enrico Weigelt, metux IT consult wrote: don't need the temporary variable "dev", directly use &pdev->dev Signed-off-by: Enrico Weigelt, metux IT consult This is quite usual to do, and I like it as it saves typing. Personally I would say don't bother with this change. --

[PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev

2019-03-11 Thread Enrico Weigelt, metux IT consult
don't need the temporary variable "dev", directly use &pdev->dev Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-janz-ttl.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-janz-ttl.c b/drivers/gpio/gpio-janz-ttl.c index b97a911