On Mon, 2007-02-19 at 11:05 +, Christoph Hellwig wrote:
> > + cond_resched();
> > + list_for_each_entry(seb, >erase, u.list)
> > + if (seb->ec == NAND_SCAN_UNKNOWN_EC)
> > + seb->ec = si->mean_ec;
>
> You really shouldn't need random cond_resched all over the
> + for (pnum = 0; pnum < io->peb_count; pnum++) {
> + cond_resched();
> +
> + err = process_eb(ubi, si, pnum);
> + if (unlikely(err < 0))
> + goto out_vidh;
> + }
> + rb_for_each_entry(rb1, sv, >volumes, rb) {
> +
+ for (pnum = 0; pnum io-peb_count; pnum++) {
+ cond_resched();
+
+ err = process_eb(ubi, si, pnum);
+ if (unlikely(err 0))
+ goto out_vidh;
+ }
+ rb_for_each_entry(rb1, sv, si-volumes, rb) {
+
On Mon, 2007-02-19 at 11:05 +, Christoph Hellwig wrote:
+ cond_resched();
+ list_for_each_entry(seb, si-erase, u.list)
+ if (seb-ec == NAND_SCAN_UNKNOWN_EC)
+ seb-ec = si-mean_ec;
You really shouldn't need random cond_resched all over the place.
Good
diff -auNrp tmp-from/drivers/mtd/ubi/scan.c tmp-to/drivers/mtd/ubi/scan.c
--- tmp-from/drivers/mtd/ubi/scan.c 1970-01-01 02:00:00.0 +0200
+++ tmp-to/drivers/mtd/ubi/scan.c 2007-02-17 18:07:26.0 +0200
@@ -0,0 +1,1383 @@
+/*
+ * Copyright (c) International Business Machines
diff -auNrp tmp-from/drivers/mtd/ubi/scan.c tmp-to/drivers/mtd/ubi/scan.c
--- tmp-from/drivers/mtd/ubi/scan.c 1970-01-01 02:00:00.0 +0200
+++ tmp-to/drivers/mtd/ubi/scan.c 2007-02-17 18:07:26.0 +0200
@@ -0,0 +1,1383 @@
+/*
+ * Copyright (c) International Business Machines
6 matches
Mail list logo
