Re: [PATCH 17/17] perf annotate: Handle variables in 'sub', 'or' and many other instructions

2018-04-17 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 17, 2018 at 11:56:28AM +0900, Namhyung Kim escreveu: > Hi, > > On Fri, Apr 13, 2018 at 10:39:40AM -0700, Andi Kleen wrote: > > > What do I miss? Or where is it that I'm misinterpreting the calculations > > > that objdump did in its output? > > > > The calculations are right, but these

Re: [PATCH 17/17] perf annotate: Handle variables in 'sub', 'or' and many other instructions

2018-04-16 Thread Namhyung Kim
Hi, On Fri, Apr 13, 2018 at 10:39:40AM -0700, Andi Kleen wrote: > > What do I miss? Or where is it that I'm misinterpreting the calculations > > that objdump did in its output? > > The calculations are right, but these are still two different address modes. > You cannot just turn one silently int

Re: [PATCH 17/17] perf annotate: Handle variables in 'sub', 'or' and many other instructions

2018-04-13 Thread Andi Kleen
> What do I miss? Or where is it that I'm misinterpreting the calculations > that objdump did in its output? The calculations are right, but these are still two different address modes. You cannot just turn one silently into the other. I think it would be ok to use the syntax in the assembler sy

Re: [PATCH 17/17] perf annotate: Handle variables in 'sub', 'or' and many other instructions

2018-04-13 Thread Arnaldo Carvalho de Melo
Em Fri, Apr 13, 2018 at 09:20:43AM -0700, Andi Kleen escreveu: > On Fri, Apr 13, 2018 at 11:01:11AM -0300, Arnaldo Carvalho de Melo wrote: > > From: Arnaldo Carvalho de Melo > > Just like is done for 'mov' and others that can have as source or > > targets variables resolved by objdump, to make th

Re: [PATCH 17/17] perf annotate: Handle variables in 'sub', 'or' and many other instructions

2018-04-13 Thread Andi Kleen
On Fri, Apr 13, 2018 at 11:01:11AM -0300, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > Just like is done for 'mov' and others that can have as source or > targets variables resolved by objdump, to make them more compact: > > - orb$0x4,0x224d71(%rip)

[PATCH 17/17] perf annotate: Handle variables in 'sub', 'or' and many other instructions

2018-04-13 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Just like is done for 'mov' and others that can have as source or targets variables resolved by objdump, to make them more compact: - orb$0x4,0x224d71(%rip)# 226ca4 <_rtld_global+0xca4> + orb$0x4,_rtld_global+0xca4 Cc: A