Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

2018-02-13 Thread Steven Rostedt
On Tue, 13 Feb 2018 18:27:37 +0900 Namhyung Kim wrote: > Hi Steve, > > On Mon, Feb 12, 2018 at 12:23:54PM -0500, Steven Rostedt wrote: > > On Mon, 12 Feb 2018 11:15:34 +0900 > > Namhyung Kim wrote: > > > > > > It should have been: > > > > > > > > return process_redirects(arg

Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

2018-02-13 Thread Namhyung Kim
Hi Steve, On Mon, Feb 12, 2018 at 12:23:54PM -0500, Steven Rostedt wrote: > On Mon, 12 Feb 2018 11:15:34 +0900 > Namhyung Kim wrote: > > > > It should have been: > > > > > > return process_redirects(arg, val, buf); > > > > But I think you need to consider data type of the arg when

Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

2018-02-12 Thread Steven Rostedt
On Mon, 12 Feb 2018 11:15:34 +0900 Namhyung Kim wrote: > > It should have been: > > > > return process_redirects(arg, val, buf); > > But I think you need to consider data type of the arg when > dereferencing the last redirect. What for? Also this code has also changed. I haven't

Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

2018-02-11 Thread Namhyung Kim
On Fri, Feb 09, 2018 at 10:47:58AM -0500, Steven Rostedt wrote: > On Fri, 9 Feb 2018 14:13:01 +0900 > Namhyung Kim wrote: > > > On Fri, Feb 02, 2018 at 06:05:15PM -0500, Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > > > Allow the function based events to retrieve not only

Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

2018-02-09 Thread Steven Rostedt
On Fri, 9 Feb 2018 10:47:58 -0500 Steven Rostedt wrote: > Good catch! > > It should have been: > > return process_redirects(arg, val, buf); Although I need to add this :-p diff --git a/kernel/trace/trace_event_ftrace.c b/kernel/trace/trace_event_ftrace.c index 673336e352be..269

Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

2018-02-09 Thread Steven Rostedt
On Fri, 9 Feb 2018 14:13:01 +0900 Namhyung Kim wrote: > On Fri, Feb 02, 2018 at 06:05:15PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > Allow the function based events to retrieve not only the parameters offsets, > > but also get data from a pointer within a paramete

Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

2018-02-08 Thread Namhyung Kim
On Fri, Feb 02, 2018 at 06:05:15PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Allow the function based events to retrieve not only the parameters offsets, > but also get data from a pointer within a parameter structure. Something > like: > > # echo 'ip_rcv(string skdev+1

[PATCH 17/18] tracing: Add indirect to indirect access for function based events

2018-02-02 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Allow the function based events to retrieve not only the parameters offsets, but also get data from a pointer within a parameter structure. Something like: # echo 'ip_rcv(string skdev+16[0][0] | x8[6] skperm+16[0]+558)' > function_events # echo 1 > events/func