Re: [PATCH 17/19] z2ram: reindent

2020-09-04 Thread Hannes Reinecke
On 9/3/20 10:01 AM, Christoph Hellwig wrote: reindent the driver using Lident as the code style was far away from normal Linux code. Signed-off-by: Christoph Hellwig --- drivers/block/z2ram.c | 493 -- 1 file changed, 236 insertions(+), 257 deletions(-

[PATCH 17/19] z2ram: reindent

2020-09-03 Thread Christoph Hellwig
reindent the driver using Lident as the code style was far away from normal Linux code. Signed-off-by: Christoph Hellwig --- drivers/block/z2ram.c | 493 -- 1 file changed, 236 insertions(+), 257 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/b

[PATCH 17/19] z2ram: reindent

2020-08-29 Thread Christoph Hellwig
reindent the driver using Lident as the code style was far away from normal Linux code. Signed-off-by: Christoph Hellwig --- drivers/block/z2ram.c | 493 -- 1 file changed, 236 insertions(+), 257 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/b

Re: [PATCH 17/19] z2ram: reindent

2020-08-27 Thread Christoph Hellwig
On Fri, Aug 28, 2020 at 10:57:46AM +1000, Finn Thain wrote: > On Thu, 27 Aug 2020, Joe Perches wrote: > > > > > checkpatch already does this. > > > > Did you use checkpatch to generate this patch? I used scripts/Lindent.

Re: [PATCH 17/19] z2ram: reindent

2020-08-27 Thread Joe Perches
On Fri, 2020-08-28 at 10:57 +1000, Finn Thain wrote: > On Thu, 27 Aug 2020, Joe Perches wrote: > > > checkpatch already does this. > > > > Did you use checkpatch to generate this patch? Nope.

Re: [PATCH 17/19] z2ram: reindent

2020-08-27 Thread Finn Thain
On Thu, 27 Aug 2020, Joe Perches wrote: > > checkpatch already does this. > Did you use checkpatch to generate this patch?

Re: [PATCH 17/19] z2ram: reindent

2020-08-27 Thread Joe Perches
On Fri, 2020-08-28 at 09:21 +1000, Finn Thain wrote: > > @@ -109,34 +111,28 @@ static void get_z2ram(void) > ... > > } > > - > > - return; > > } > > > > It would be good to have a semantic patch for that change. > > > > > - if (z2ram_map[z2ram_size] == 0) { > > + if

Re: [PATCH 17/19] z2ram: reindent

2020-08-27 Thread Finn Thain
> @@ -109,34 +111,28 @@ static void get_z2ram(void) ... > } > - > - return; > } > It would be good to have a semantic patch for that change. > > - if (z2ram_map[z2ram_size] == 0) { > + if (z2ram_map[z2ram_size] == 0) > break; > -

Re: [PATCH 17/19] z2ram: reindent

2020-08-26 Thread Joe Perches
On Wed, 2020-08-26 at 11:49 +0200, John Paul Adrian Glaubitz wrote: > > On Aug 26, 2020, at 11:21 AM, Joe Perches wrote: > > > > On Wed, 2020-08-26 at 08:24 +0200, Christoph Hellwig wrote: > > > reindent the driver using Lident as the code style was far away from > > > normal Linux code. > > >

Re: [PATCH 17/19] z2ram: reindent

2020-08-26 Thread John Paul Adrian Glaubitz
> On Aug 26, 2020, at 11:21 AM, Joe Perches wrote: > > On Wed, 2020-08-26 at 08:24 +0200, Christoph Hellwig wrote: >> reindent the driver using Lident as the code style was far away from >> normal Linux code. > > Why? Does anyone use this anymore? Yes, the Amiga and Linux/m68k is very well

Re: [PATCH 17/19] z2ram: reindent

2020-08-26 Thread Joe Perches
On Wed, 2020-08-26 at 08:24 +0200, Christoph Hellwig wrote: > reindent the driver using Lident as the code style was far away from > normal Linux code. Why? Does anyone use this anymore? ** z2ram - Amiga pseudo-driver to access 16bit-RAM in ZorroII space ** as a block device, to be use

[PATCH 17/19] z2ram: reindent

2020-08-26 Thread Christoph Hellwig
reindent the driver using Lident as the code style was far away from normal Linux code. Signed-off-by: Christoph Hellwig --- drivers/block/z2ram.c | 497 -- 1 file changed, 237 insertions(+), 260 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/b