Re: [PATCH 17/23] mm: count writeback pages per BDI

2007-08-13 Thread Peter Zijlstra
On Thu, 2007-08-09 at 12:27 -0700, Christoph Lameter wrote: > On Thu, 9 Aug 2007, Peter Zijlstra wrote: > > > Less conditionals. We already have a branch for mapping, why create > > another? > > Ah. Okay. This also avoids an interrupt enable disable since you can use > __ functions. Hmmm...

Re: [PATCH 17/23] mm: count writeback pages per BDI

2007-08-13 Thread Peter Zijlstra
On Thu, 2007-08-09 at 12:27 -0700, Christoph Lameter wrote: On Thu, 9 Aug 2007, Peter Zijlstra wrote: Less conditionals. We already have a branch for mapping, why create another? Ah. Okay. This also avoids an interrupt enable disable since you can use __ functions. Hmmm... Would be

Re: [PATCH 17/23] mm: count writeback pages per BDI

2007-08-09 Thread Christoph Lameter
On Thu, 9 Aug 2007, Peter Zijlstra wrote: > Less conditionals. We already have a branch for mapping, why create > another? Ah. Okay. This also avoids an interrupt enable disable since you can use __ functions. Hmmm... Would be good if we could move the vmstat NR_WRITEBACK update there too. Can

Re: [PATCH 17/23] mm: count writeback pages per BDI

2007-08-09 Thread Peter Zijlstra
On Thu, 2007-08-09 at 12:15 -0700, Christoph Lameter wrote: > On Fri, 3 Aug 2007, Peter Zijlstra wrote: > > > page_index(page), > > PAGECACHE_TAG_WRITEBACK); > > + if

Re: [PATCH 17/23] mm: count writeback pages per BDI

2007-08-09 Thread Christoph Lameter
On Fri, 3 Aug 2007, Peter Zijlstra wrote: > page_index(page), > PAGECACHE_TAG_WRITEBACK); > + if (bdi_cap_writeback_dirty(bdi)) > + __dec_bdi_stat(bdi,

Re: [PATCH 17/23] mm: count writeback pages per BDI

2007-08-09 Thread Christoph Lameter
On Fri, 3 Aug 2007, Peter Zijlstra wrote: page_index(page), PAGECACHE_TAG_WRITEBACK); + if (bdi_cap_writeback_dirty(bdi)) + __dec_bdi_stat(bdi,

Re: [PATCH 17/23] mm: count writeback pages per BDI

2007-08-09 Thread Peter Zijlstra
On Thu, 2007-08-09 at 12:15 -0700, Christoph Lameter wrote: On Fri, 3 Aug 2007, Peter Zijlstra wrote: page_index(page), PAGECACHE_TAG_WRITEBACK); + if (bdi_cap_writeback_dirty(bdi))

Re: [PATCH 17/23] mm: count writeback pages per BDI

2007-08-09 Thread Christoph Lameter
On Thu, 9 Aug 2007, Peter Zijlstra wrote: Less conditionals. We already have a branch for mapping, why create another? Ah. Okay. This also avoids an interrupt enable disable since you can use __ functions. Hmmm... Would be good if we could move the vmstat NR_WRITEBACK update there too. Can a

[PATCH 17/23] mm: count writeback pages per BDI

2007-08-03 Thread Peter Zijlstra
Count per BDI writeback pages. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/backing-dev.h |1 + mm/page-writeback.c | 12 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) Index: linux-2.6/mm/page-writeback.c

[PATCH 17/23] mm: count writeback pages per BDI

2007-08-03 Thread Peter Zijlstra
Count per BDI writeback pages. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- include/linux/backing-dev.h |1 + mm/page-writeback.c | 12 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) Index: linux-2.6/mm/page-writeback.c