Re: [PATCH 17/33] aio: change reqs_active to include unreaped completions

2013-04-02 Thread Theodore Ts'o
On Mon, Apr 01, 2013 at 10:53:50PM -0400, Theodore Ts'o wrote: > Could you please add a quick comment documenting the reqs_active field > in the struct kioctx definition here? For future code > maintainability, it should be documented in fs/aio.c, not just in a > commit description. I see this fi

Re: [PATCH 17/33] aio: change reqs_active to include unreaped completions

2013-04-01 Thread Theodore Ts'o
On Thu, Mar 21, 2013 at 09:35:38AM -0700, Kent Overstreet wrote: > The aio code tries really hard to avoid having to deal with the completion > ringbuffer overflowing. To do that, it has to keep track of the number of > outstanding kiocbs, and the number of completions currently in the > ringbuffe

[PATCH 17/33] aio: change reqs_active to include unreaped completions

2013-03-21 Thread Kent Overstreet
The aio code tries really hard to avoid having to deal with the completion ringbuffer overflowing. To do that, it has to keep track of the number of outstanding kiocbs, and the number of completions currently in the ringbuffer - and it's got to check that every time we allocate a kiocb. Ouch. But