Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Krzysztof Kozlowski
On Wed, Feb 10, 2021 at 03:19:46PM +0200, Tony Lindgren wrote: > * Krzysztof Kozlowski [210210 12:56]: > > On Wed, Feb 10, 2021 at 01:34:50PM +0200, Tony Lindgren wrote: > > > * Hector Martin [210210 11:14]: > > > > On 10/02/2021 19.19, Tony Lindgren wrote: > > > > > * Hector Martin 'marcan'

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Tony Lindgren
* Krzysztof Kozlowski [210210 12:56]: > On Wed, Feb 10, 2021 at 01:34:50PM +0200, Tony Lindgren wrote: > > * Hector Martin [210210 11:14]: > > > On 10/02/2021 19.19, Tony Lindgren wrote: > > > > * Hector Martin 'marcan' [210208 12:05]: > > > > > On 08/02/2021 20.04, Krzysztof Kozlowski wrote: >

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Hector Martin
On 10/02/2021 21.24, Daniel Palmer wrote: This exact problem exists for MStar/SigmaStar too. As it stands there is no documentation to show what the actual clock tree looks like so everything is guess and I need to come up with numbers. I'm interested to see what the solution to this is as it

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Krzysztof Kozlowski
On Wed, Feb 10, 2021 at 01:34:50PM +0200, Tony Lindgren wrote: > * Hector Martin [210210 11:14]: > > On 10/02/2021 19.19, Tony Lindgren wrote: > > > * Hector Martin 'marcan' [210208 12:05]: > > > > On 08/02/2021 20.04, Krzysztof Kozlowski wrote: > > > ... > > > > > > > > > + clk24: clk24 { >

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Tony Lindgren
* Daniel Palmer [210210 12:24]: > Hi Hector, > > On Wed, 10 Feb 2021 at 20:49, Hector Martin wrote: > > > > Yeah, just don't use an imaginary dummy index for the reg. Use a real > > > register offset from a clock controller instance base, and a register > > > bit offset too if needed. > > > >

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Daniel Palmer
Hi Hector, On Wed, 10 Feb 2021 at 20:49, Hector Martin wrote: > > Yeah, just don't use an imaginary dummy index for the reg. Use a real > > register offset from a clock controller instance base, and a register > > bit offset too if needed. > > I mean for fixed input clocks without any

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Hector Martin
On 10/02/2021 20.34, Tony Lindgren wrote: * Hector Martin [210210 11:14]: That means it'll end up like this (so that we can have more than one fixed-clock): clocks { #address-cells = <1>; #size-cells = <0>; clk123: clock@0 { ... reg = <0> } clk456:

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Tony Lindgren
* Hector Martin [210210 11:14]: > On 10/02/2021 19.19, Tony Lindgren wrote: > > * Hector Martin 'marcan' [210208 12:05]: > > > On 08/02/2021 20.04, Krzysztof Kozlowski wrote: > > ... > > > > > > > + clk24: clk24 { > > > > > > > > Just "clock". Node names should be generic. > > > > > >

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Hector Martin
On 10/02/2021 19.19, Tony Lindgren wrote: * Hector Martin 'marcan' [210208 12:05]: On 08/02/2021 20.04, Krzysztof Kozlowski wrote: ... + clk24: clk24 { Just "clock". Node names should be generic. Really? Almost every other device device tree uses unique clock node names. Yeah

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Tony Lindgren
* Hector Martin 'marcan' [210208 12:05]: > On 08/02/2021 20.04, Krzysztof Kozlowski wrote: ... > > > + clk24: clk24 { > > > > Just "clock". Node names should be generic. > > Really? Almost every other device device tree uses unique clock node names. Yeah please just use generic node name

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-08 Thread Hector Martin
On 09/02/2021 04.14, Rob Herring wrote: Does there need to be a legal entity behind 'The Asahi Linux Contributors' to be valid? I don't think so, this seems to be common practice in other open source projects, and recommended these days. Some recent discussion on the subject from the Linux

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-08 Thread Hector Martin
On 09/02/2021 02.58, Rob Herring wrote: I'll also highlight there's a DT only tree[1] available to import DT related parts to other projects. It's generated from the kernel tree. Probably an overkill to copying at this point though. Rob [1]

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-08 Thread Rob Herring
On Mon, Feb 08, 2021 at 08:56:53PM +0900, Hector Martin 'marcan' wrote: > On 08/02/2021 20.04, Krzysztof Kozlowski wrote: > > apple > > > > Don't make things different for this one platform (comparing to all > > other platforms). Apple is not that special. :) > > AAPL is the old vendor prefix

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-08 Thread Rob Herring
On Mon, Feb 08, 2021 at 11:12:52PM +0900, Hector Martin wrote: > On 08/02/2021 21.40, Arnd Bergmann wrote: > > On Mon, Feb 8, 2021 at 1:13 PM Krzysztof Kozlowski wrote: > > > > > > On Mon, Feb 08, 2021 at 08:56:53PM +0900, Hector Martin 'marcan' wrote: > > > > On 08/02/2021 20.04, Krzysztof

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-08 Thread Hector Martin
On 08/02/2021 21.27, Marc Zyngier wrote: + timer { + compatible = "arm,armv8-timer"; + interrupt-parent = <>; + interrupts = , + , + , + ; This

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-08 Thread Hector Martin
On 08/02/2021 21.40, Arnd Bergmann wrote: On Mon, Feb 8, 2021 at 1:13 PM Krzysztof Kozlowski wrote: On Mon, Feb 08, 2021 at 08:56:53PM +0900, Hector Martin 'marcan' wrote: On 08/02/2021 20.04, Krzysztof Kozlowski wrote: apple Don't make things different for this one platform (comparing to

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-08 Thread Krzysztof Kozlowski
On Mon, Feb 08, 2021 at 08:56:53PM +0900, Hector Martin 'marcan' wrote: > On 08/02/2021 20.04, Krzysztof Kozlowski wrote: > > apple > > > > Don't make things different for this one platform (comparing to all > > other platforms). Apple is not that special. :) > > AAPL is the old vendor prefix

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-08 Thread Hector Martin 'marcan'
On 08/02/2021 20.04, Krzysztof Kozlowski wrote: apple Don't make things different for this one platform (comparing to all other platforms). Apple is not that special. :) AAPL is the old vendor prefix used in the PowerPC era. I'm happy to use `apple`, as long as we're OK with having two

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-08 Thread Krzysztof Kozlowski
On Fri, Feb 05, 2021 at 05:39:51AM +0900, Hector Martin wrote: > This currently supports: > > * SMP (via spin-tables) > * AIC IRQs > * Serial (with earlycon) > * Framebuffer > > A number of properties are dynamic, and based on system firmware > decisions that vary from version to version. These

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-04 Thread Hector Martin 'marcan'
On 05/02/2021 08.08, Arnd Bergmann wrote: On Thu, Feb 4, 2021 at 10:44 PM Hector Martin 'marcan' wrote: On 05/02/2021 06.29, Arnd Bergmann wrote: On Thu, Feb 4, 2021 at 9:39 PM Hector Martin wrote: We tend to split the dts file into one file per SoC and one for the specific board. I guess

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-04 Thread Hector Martin 'marcan'
On 05/02/2021 06.29, Arnd Bergmann wrote: On Thu, Feb 4, 2021 at 9:39 PM Hector Martin wrote: +/ { + model = "Apple Mac Mini M1 2020"; + compatible = "AAPL,j274", "AAPL,m1", "AAPL,arm-platform"; + #address-cells = <2>; + #size-cells = <2>; + + chosen { +

[PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-04 Thread Hector Martin
This currently supports: * SMP (via spin-tables) * AIC IRQs * Serial (with earlycon) * Framebuffer A number of properties are dynamic, and based on system firmware decisions that vary from version to version. These are expected to be filled in by the loader. Signed-off-by: Hector Martin ---