Re: [PATCH 18/19] clocksource: add timer-nationalchip.c

2018-03-19 Thread Guo Ren
Hi Mark, On Mon, Mar 19, 2018 at 04:15:35AM +, Mark Rutland wrote: > > +#define NC_VA_COUNTER_3_CONTROL(void *)(timer_reg + 0x90) > > +#define NC_VA_COUNTER_3_CONFIG (void *)(timer_reg + 0xa0) > > +#define NC_VA_COUNTER_3_PRE(void *)(timer_reg + 0xa4) >

Re: [PATCH 18/19] clocksource: add timer-nationalchip.c

2018-03-19 Thread Guo Ren
Hi Daniel, On Sun, Mar 18, 2018 at 11:07:12PM +0100, Daniel Lezcano wrote: > > This patch is a new driver. Please add the hardware details of this > timer and optionally a link to the documentation. No need to write a > book, just a quick summary of it. > OK > > +#include > > +#include > > +#i

Re: [PATCH 18/19] clocksource: add timer-nationalchip.c

2018-03-18 Thread Mark Rutland
Hi, On Mon, Mar 19, 2018 at 03:51:40AM +0800, Guo Ren wrote: > +#define NC_VA_COUNTER_1_STATUS (void *)(timer_reg + 0x00) > +#define NC_VA_COUNTER_1_VALUE(void *)(timer_reg + 0x04) > +#define NC_VA_COUNTER_1_CONTROL (void *)(timer_reg + 0x10) > +#define N

Re: [PATCH 18/19] clocksource: add timer-nationalchip.c

2018-03-18 Thread Daniel Lezcano
Hi Guo, On 18/03/2018 20:51, Guo Ren wrote: This patch is a new driver. Please add the hardware details of this timer and optionally a link to the documentation. No need to write a book, just a quick summary of it. > Signed-off-by: Guo Ren > --- > drivers/clocksource/Makefile |

[PATCH 18/19] clocksource: add timer-nationalchip.c

2018-03-18 Thread Guo Ren
Signed-off-by: Guo Ren --- drivers/clocksource/Makefile | 1 + drivers/clocksource/timer-nationalchip.c | 149 +++ 2 files changed, 150 insertions(+) create mode 100644 drivers/clocksource/timer-nationalchip.c diff --git a/drivers/clocksource/Makefile b