Re: [PATCH 18/22] watchdog: mt7621_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Hi Joe, On Wed, Apr 10, 2019 at 03:10:09PM -0700, Joe Perches wrote: > On Wed, 2019-04-10 at 12:54 -0700, Guenter Roeck wrote: > > A checkpatch rule suggesting that multiple extension lines can be merged > > might be useful to help finding such situations. Just a thought. > > You are welcome to t

Re: [PATCH 18/22] watchdog: mt7621_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Joe Perches
On Wed, 2019-04-10 at 12:54 -0700, Guenter Roeck wrote: > A checkpatch rule suggesting that multiple extension lines can be merged > might be useful to help finding such situations. Just a thought. You are welcome to try to write that one. It's likely not a trivial task to make it sensible. cheer

Re: [PATCH 18/22] watchdog: mt7621_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2019 at 11:46:24AM -0700, Joe Perches wrote: > On Wed, 2019-04-10 at 09:27 -0700, Guenter Roeck wrote: > > Introduce local variable 'struct device *dev' and use it instead of > > dereferencing it repeatedly. > > > > The conversion was done automatically with coccinelle using the >

Re: [PATCH 18/22] watchdog: mt7621_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Joe Perches
On Wed, 2019-04-10 at 09:27 -0700, Guenter Roeck wrote: > Introduce local variable 'struct device *dev' and use it instead of > dereferencing it repeatedly. > > The conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used

[PATCH 18/22] watchdog: mt7621_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro