Re: [PATCH 18/23] [AARCH64] ILP32: support stat syscall family

../sysdeps/unix/sysv/linux/aarch64/ilp32/lxstat64.c: In function '__lxstat64': ../sysdeps/unix/sysv/linux/aarch64/ilp32/lxstat64.c:32:7: error: unused variable 'result' [-Werror=unused-variable] int result; ^~ Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerpri

Re: [PATCH 18/23] [AARCH64] ILP32: support stat syscall family

Yury Norov writes: > +#ifdef __ILP32__ > +#include > +struct __kernel_timespec > + { > +unsigned long long tv_sec; /* Seconds. */ > +long long tv_nsec; /* Nanoseconds. */ > + }; > +#define conv_timespec(u, k) do { \ > + (u)->tv_sec = (k)->t

Re: [PATCH 18/23] [AARCH64] ILP32: support stat syscall family

On Tue, 28 Jun 2016, Yury Norov wrote: > What you talk about sounds unclear to me. If you mean to unify with > one of existing ports, it looks unnecessary, as ilp32 will end up with > RISC-V anyway. If you mean to use RISC-V, it's not ready yet. I was > thinking that when they will finish, they s

Re: [PATCH 18/23] [AARCH64] ILP32: support stat syscall family

On 28/06/2016 16:08, Yury Norov wrote: > On Tue, Jun 28, 2016 at 05:15:13PM +, Joseph Myers wrote: >> still >> applies. Unify implementations instead of proliferating variants. > > I think on it. I don't see simple way to unify i

Re: [PATCH 18/23] [AARCH64] ILP32: support stat syscall family

On Tue, Jun 28, 2016 at 05:15:13PM +, Joseph Myers wrote: > still > applies. Unify implementations instead of proliferating variants. I think on it. I don't see simple way to unify it right now. And I plan to take a vacation in nex

Re: [PATCH 18/23] [AARCH64] ILP32: support stat syscall family

still applies. Unify implementations instead of proliferating variants. Also, much of the formatting is way off the GNU Coding Standards (e.g. indentation that's not two-column, "{" not on a line by itself), and you're missing descri

[PATCH 18/23] [AARCH64] ILP32: support stat syscall family

From: Yury Norov stat and statfs structures has their layouts identical to lp64 after changing off_t, ino_t etc sizes to 64-bit. It means we can pass it to kernel same way as lp64 does. Signed-off-by: Yury Norov --- sysdeps/unix/sysv/linux/aarch64/bits/stat.h| 195 +