Re: [PATCH 18/25][V3] turn priviled operations into macros in entry.S

2007-08-15 Thread Glauber de Oliveira Costa
> > Is the .globl really required here? I would think that the reference in > the fixup section would be resolved with in the compiling of this object. > For the fixup yes, you are right. But I'm using this symbol in paravirt.c now, to denote the native operation. -- Glauber de Oliveira Costa. "F

Re: [PATCH 18/25][V3] turn priviled operations into macros in entry.S

2007-08-15 Thread Steven Rostedt
-- On Wed, 15 Aug 2007, Glauber de Oliveira Costa wrote: > @@ -566,10 +596,15 @@ retint_restore_args: > restore_args: > RESTORE_ARGS 0,8,0 > iret_label: > +#ifdef CONFIG_PARAVIRT > + INTERRUPT_RETURN > +#endif > +.globl do_iretq; Is the .globl really required here? I would think th

[PATCH 18/25][V3] turn priviled operations into macros in entry.S

2007-08-15 Thread Glauber de Oliveira Costa
With paravirt on, we cannot issue operations like swapgs, sysretq, iretq, cli, sti. So they have to be changed into macros, that will be later properly replaced for the paravirt case. The sysretq is a little bit more complicated, and is replaced by a sequence of three instructions. It is basically