Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Peter Zijlstra
On Sat, 2007-02-24 at 17:40 +0100, Patrick McHardy wrote: > Peter Zijlstra wrote: > > On Sat, 2007-02-24 at 17:17 +0100, Patrick McHardy wrote: > > > > > >>I don't really see why > >>queueing is special though, dropping the packets in the ruleset > >>will break things just as well, as will

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Patrick McHardy
Peter Zijlstra wrote: > On Sat, 2007-02-24 at 17:17 +0100, Patrick McHardy wrote: > > >>I don't really see why >>queueing is special though, dropping the packets in the ruleset >>will break things just as well, as will routing them to a blackhole. >>I guess the user just needs to be smart enough

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Peter Zijlstra
On Sat, 2007-02-24 at 17:17 +0100, Patrick McHardy wrote: > I don't really see why > queueing is special though, dropping the packets in the ruleset > will break things just as well, as will routing them to a blackhole. > I guess the user just needs to be smart enough not to do this. Its

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Patrick McHardy
Peter Zijlstra wrote: > On Sat, 2007-02-24 at 16:27 +0100, Patrick McHardy wrote: > >>> } else if ((verdict & NF_VERDICT_MASK) == NF_QUEUE) { >>>+if (unlikely((*pskb)->emergency)) { >>>+printk(KERN_ERR "nf_hook: NF_QUEUE encountered for " >>>+

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Peter Zijlstra
On Sat, 2007-02-24 at 16:27 +0100, Patrick McHardy wrote: > Peter Zijlstra wrote: > > Emergency skbs should never touch user-space, however NF_QUEUE is fully user > > configurable. Notify the user of his mistake and try to continue. > > > > --- linux-2.6-git.orig/net/netfilter/core.c 2007-02-14

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Patrick McHardy
Peter Zijlstra wrote: > Emergency skbs should never touch user-space, however NF_QUEUE is fully user > configurable. Notify the user of his mistake and try to continue. > > --- linux-2.6-git.orig/net/netfilter/core.c 2007-02-14 12:09:07.0 > +0100 > +++ linux-2.6-git/net/netfilter/core.c

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Patrick McHardy
Peter Zijlstra wrote: Emergency skbs should never touch user-space, however NF_QUEUE is fully user configurable. Notify the user of his mistake and try to continue. --- linux-2.6-git.orig/net/netfilter/core.c 2007-02-14 12:09:07.0 +0100 +++ linux-2.6-git/net/netfilter/core.c

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Peter Zijlstra
On Sat, 2007-02-24 at 16:27 +0100, Patrick McHardy wrote: Peter Zijlstra wrote: Emergency skbs should never touch user-space, however NF_QUEUE is fully user configurable. Notify the user of his mistake and try to continue. --- linux-2.6-git.orig/net/netfilter/core.c 2007-02-14

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Patrick McHardy
Peter Zijlstra wrote: On Sat, 2007-02-24 at 16:27 +0100, Patrick McHardy wrote: } else if ((verdict NF_VERDICT_MASK) == NF_QUEUE) { +if (unlikely((*pskb)-emergency)) { +printk(KERN_ERR nf_hook: NF_QUEUE encountered for +

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Peter Zijlstra
On Sat, 2007-02-24 at 17:17 +0100, Patrick McHardy wrote: I don't really see why queueing is special though, dropping the packets in the ruleset will break things just as well, as will routing them to a blackhole. I guess the user just needs to be smart enough not to do this. Its user-space

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Patrick McHardy
Peter Zijlstra wrote: On Sat, 2007-02-24 at 17:17 +0100, Patrick McHardy wrote: I don't really see why queueing is special though, dropping the packets in the ruleset will break things just as well, as will routing them to a blackhole. I guess the user just needs to be smart enough not to do

Re: [PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-24 Thread Peter Zijlstra
On Sat, 2007-02-24 at 17:40 +0100, Patrick McHardy wrote: Peter Zijlstra wrote: On Sat, 2007-02-24 at 17:17 +0100, Patrick McHardy wrote: I don't really see why queueing is special though, dropping the packets in the ruleset will break things just as well, as will routing them to a

[PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-21 Thread Peter Zijlstra
Emergency skbs should never touch user-space, however NF_QUEUE is fully user configurable. Notify the user of his mistake and try to continue. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- net/netfilter/core.c |5 + 1 file changed, 5 insertions(+) Index:

[PATCH 18/29] netfilter: notify about NF_QUEUE vs emergency skbs

2007-02-21 Thread Peter Zijlstra
Emergency skbs should never touch user-space, however NF_QUEUE is fully user configurable. Notify the user of his mistake and try to continue. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- net/netfilter/core.c |5 + 1 file changed, 5 insertions(+) Index: