Re: [PATCH 19/23] sysctl: Call sysctl_head_finish on error

2020-07-02 Thread Al Viro
On Thu, Jul 02, 2020 at 07:15:12AM +0200, Christoph Hellwig wrote: > On Thu, Jul 02, 2020 at 01:32:40AM +0100, Matthew Wilcox wrote: > > On Wed, Jul 01, 2020 at 10:09:47PM +0200, Christoph Hellwig wrote: > > > From: "Matthew Wilcox (Oracle)" > > > > > > This error path returned directly instead

Re: [PATCH 19/23] sysctl: Call sysctl_head_finish on error

2020-07-01 Thread Christoph Hellwig
On Thu, Jul 02, 2020 at 01:32:40AM +0100, Matthew Wilcox wrote: > On Wed, Jul 01, 2020 at 10:09:47PM +0200, Christoph Hellwig wrote: > > From: "Matthew Wilcox (Oracle)" > > > > This error path returned directly instead of calling sysctl_head_finish(). > > > > Fixes: ef9d965bc8b6 ("sysctl:

Re: [PATCH 19/23] sysctl: Call sysctl_head_finish on error

2020-07-01 Thread Matthew Wilcox
On Wed, Jul 01, 2020 at 10:09:47PM +0200, Christoph Hellwig wrote: > From: "Matthew Wilcox (Oracle)" > > This error path returned directly instead of calling sysctl_head_finish(). > > Fixes: ef9d965bc8b6 ("sysctl: reject gigantic reads/write to sysctl files") > Signed-off-by: Matthew Wilcox

[PATCH 19/23] sysctl: Call sysctl_head_finish on error

2020-07-01 Thread Christoph Hellwig
From: "Matthew Wilcox (Oracle)" This error path returned directly instead of calling sysctl_head_finish(). Fixes: ef9d965bc8b6 ("sysctl: reject gigantic reads/write to sysctl files") Signed-off-by: Matthew Wilcox (Oracle) --- fs/proc/proc_sysctl.c | 6 +++--- 1 file changed, 3 insertions(+),