Hi Peter
Thanks for the patch, but I think it can be improved:
On Sun, 23 Sep 2012, Mauro Carvalho Chehab wrote:
> Please review,
>
> Regards,
> Mauro.
>
>
> Mensagem original ----
> Assunto: [PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c:
Please review,
Regards,
Mauro.
Mensagem original
Assunto: [PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix error
return code
Data: Thu, 6 Sep 2012 17:23:59 +0200
De: Peter Senna Tschudin
Para: Mauro Carvalho Chehab
CC: kernel-janit...@vger.kernel.org
Please review,
Regards,
Mauro.
Mensagem original
Assunto: [PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix error
return code
Data: Thu, 6 Sep 2012 17:23:59 +0200
De: Peter Senna Tschudin peter.se...@gmail.com
Para: Mauro Carvalho Chehab mche...@infradead.org
Hi Peter
Thanks for the patch, but I think it can be improved:
On Sun, 23 Sep 2012, Mauro Carvalho Chehab wrote:
Please review,
Regards,
Mauro.
Mensagem original
Assunto: [PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix
error return code
Data: Thu
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin peter.se...@gmail.com
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
(
if@p1 (\(ret 0\|ret !=
6 matches
Mail list logo
