Re: [PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 11:51:21PM +, Adrian McMenamin wrote: > Replacement second-in-series patch: > > This patch fixes up memory leaks and, by delaying initialisation, makes > device detection more robust. > > It also makes clearer the difference between struct maple_device and > struct dev

Re: [PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
Replacement second-in-series patch: This patch fixes up memory leaks and, by delaying initialisation, makes device detection more robust. It also makes clearer the difference between struct maple_device and struct device, as well as cleaning up the interrupt request code (without changing its fun

Re: [PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 11:05:14PM +, Adrian McMenamin wrote: > > On Wed, 2008-02-06 at 15:01 -0800, Greg KH wrote: > > On Wed, Feb 06, 2008 at 10:53:51PM +, Adrian McMenamin wrote: > > > - dev->function = function; > > > - dev->dev.bus = &maple_bus_type; > > > - dev->dev.parent = &maple_b

Re: [PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
On Wed, 2008-02-06 at 15:01 -0800, Greg KH wrote: > On Wed, Feb 06, 2008 at 10:53:51PM +, Adrian McMenamin wrote: > > - dev->function = function; > > - dev->dev.bus = &maple_bus_type; > > - dev->dev.parent = &maple_bus; > > - dev->dev.release = &maple_release_device; > > - retval = d

Re: [PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 10:53:51PM +, Adrian McMenamin wrote: > - dev->function = function; > - dev->dev.bus = &maple_bus_type; > - dev->dev.parent = &maple_bus; > - dev->dev.release = &maple_release_device; > - retval = device_register(&dev->dev); > - if (retval) { > -

[PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
This patch fixes up memory leaks and, by delaying initialisation, makes device detection more robust. It also makes clearer the difference between struct maple_device and struct device, as well as cleaning up the interrupt request code (without changing its function in any way). Signed-off by: Ad