Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread David Howells
Hugh Dickins <[EMAIL PROTECTED]> wrote: > > VM in a way that people are not unhappy with :) > > I'm hoping you intended one less negative ;) Or did you mean one fewer negative? :-) David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Chuck Ebbert
Hugh Dickins wrote: > On Thu, 17 May 2007, Nick Piggin wrote: >> ... and I don't want to change the >> VM in a way that people are not unhappy with :) > > I'm hoping you intended one less negative ;) Or one more... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Nick Piggin
Hugh Dickins wrote: On Thu, 17 May 2007, Nick Piggin wrote: ... and I don't want to change the VM in a way that people are not unhappy with :) I'm hoping you intended one less negative ;) Derrr... I'm an idiot! -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Hugh Dickins
On Thu, 17 May 2007, Nick Piggin wrote: > > ... and I don't want to change the > VM in a way that people are not unhappy with :) I'm hoping you intended one less negative ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Nick Piggin
Hugh Dickins wrote: On Wed, 16 May 2007, Nick Piggin wrote: Andrew Morton wrote: I need to work out what to do with mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch mm-merge-populate-and-nopage-into-fault-fixes-nonlinear.patch

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Hugh Dickins
On Wed, 16 May 2007, Nick Piggin wrote: > Andrew Morton wrote: > > I need to work out what to do with > > > > mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch > > mm-merge-populate-and-nopage-into-fault-fixes-nonlinear.patch > >

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Nick Piggin
Christoph Hellwig wrote: On Tue, May 15, 2007 at 04:52:31PM +0100, David Howells wrote: +int afs_page_mkwrite(struct vm_area_struct *vma, struct page *page) +{ + struct afs_vnode *vnode = AFS_FS_I(vma->vm_file->f_mapping->host); + struct key *key = vma->vm_file->private_data; +

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Christoph Hellwig
On Tue, May 15, 2007 at 04:52:31PM +0100, David Howells wrote: > +int afs_page_mkwrite(struct vm_area_struct *vma, struct page *page) > +{ > + struct afs_vnode *vnode = AFS_FS_I(vma->vm_file->f_mapping->host); > + struct key *key = vma->vm_file->private_data; > + int ret; > + > +

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Christoph Hellwig
On Tue, May 15, 2007 at 04:52:31PM +0100, David Howells wrote: +int afs_page_mkwrite(struct vm_area_struct *vma, struct page *page) +{ + struct afs_vnode *vnode = AFS_FS_I(vma-vm_file-f_mapping-host); + struct key *key = vma-vm_file-private_data; + int ret; + +

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Nick Piggin
Christoph Hellwig wrote: On Tue, May 15, 2007 at 04:52:31PM +0100, David Howells wrote: +int afs_page_mkwrite(struct vm_area_struct *vma, struct page *page) +{ + struct afs_vnode *vnode = AFS_FS_I(vma-vm_file-f_mapping-host); + struct key *key = vma-vm_file-private_data; +

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Hugh Dickins
On Wed, 16 May 2007, Nick Piggin wrote: Andrew Morton wrote: I need to work out what to do with mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch mm-merge-populate-and-nopage-into-fault-fixes-nonlinear.patch mm-merge-populate-and-nopage-into-fault-fixes-nonlinear-doc-fix.patch

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Nick Piggin
Hugh Dickins wrote: On Wed, 16 May 2007, Nick Piggin wrote: Andrew Morton wrote: I need to work out what to do with mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch mm-merge-populate-and-nopage-into-fault-fixes-nonlinear.patch

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Hugh Dickins
On Thu, 17 May 2007, Nick Piggin wrote: ... and I don't want to change the VM in a way that people are not unhappy with :) I'm hoping you intended one less negative ;) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Nick Piggin
Hugh Dickins wrote: On Thu, 17 May 2007, Nick Piggin wrote: ... and I don't want to change the VM in a way that people are not unhappy with :) I'm hoping you intended one less negative ;) Derrr... I'm an idiot! -- - To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread Chuck Ebbert
Hugh Dickins wrote: On Thu, 17 May 2007, Nick Piggin wrote: ... and I don't want to change the VM in a way that people are not unhappy with :) I'm hoping you intended one less negative ;) Or one more... - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-16 Thread David Howells
Hugh Dickins [EMAIL PROTECTED] wrote: VM in a way that people are not unhappy with :) I'm hoping you intended one less negative ;) Or did you mean one fewer negative? :-) David - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread Nick Piggin
Andrew Morton wrote: On Tue, 15 May 2007 16:52:31 +0100 David Howells <[EMAIL PROTECTED]> wrote: Implement shared-writable mmap for AFS. This blows up in -mm: fs/afs/file.c:59: error: 'filemap_nopage' undeclared here (not in a function) fs/afs/file.c:60: error: unknown field 'populate'

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread Nick Piggin
David Howells wrote: Implement shared-writable mmap for AFS. The key with which to access the file is obtained from the VMA at the point where the PTE is made writable by the page_mkwrite() VMA op and cached in the affected page. If there's an outstanding write on the page made with a

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread Andrew Morton
On Tue, 15 May 2007 16:52:31 +0100 David Howells <[EMAIL PROTECTED]> wrote: > Implement shared-writable mmap for AFS. This blows up in -mm: fs/afs/file.c:59: error: 'filemap_nopage' undeclared here (not in a function) fs/afs/file.c:60: error: unknown field 'populate' specified in initializer

[PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread David Howells
Implement shared-writable mmap for AFS. The key with which to access the file is obtained from the VMA at the point where the PTE is made writable by the page_mkwrite() VMA op and cached in the affected page. If there's an outstanding write on the page made with a different key, then

[PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread David Howells
Implement shared-writable mmap for AFS. The key with which to access the file is obtained from the VMA at the point where the PTE is made writable by the page_mkwrite() VMA op and cached in the affected page. If there's an outstanding write on the page made with a different key, then

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread Andrew Morton
On Tue, 15 May 2007 16:52:31 +0100 David Howells [EMAIL PROTECTED] wrote: Implement shared-writable mmap for AFS. This blows up in -mm: fs/afs/file.c:59: error: 'filemap_nopage' undeclared here (not in a function) fs/afs/file.c:60: error: unknown field 'populate' specified in initializer

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread Nick Piggin
David Howells wrote: Implement shared-writable mmap for AFS. The key with which to access the file is obtained from the VMA at the point where the PTE is made writable by the page_mkwrite() VMA op and cached in the affected page. If there's an outstanding write on the page made with a

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread Nick Piggin
Andrew Morton wrote: On Tue, 15 May 2007 16:52:31 +0100 David Howells [EMAIL PROTECTED] wrote: Implement shared-writable mmap for AFS. This blows up in -mm: fs/afs/file.c:59: error: 'filemap_nopage' undeclared here (not in a function) fs/afs/file.c:60: error: unknown field 'populate'