Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-01-20 Thread Eddie Cai
2017-01-20 16:12 GMT+08:00 Heiko Stuebner : > Hi Eddie, > > Am Freitag, 20. Januar 2017, 15:10:47 CET schrieb Eddie Cai: >> 2017-01-19 17:58 GMT+08:00 Heiko Stuebner : >> > Hi Eddie, >> > >> > Am Donnerstag, 19. Januar 2017, 10:11:59 CET schrieb Eddie Cai: >> >> This patch add basic support for RK3

Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-01-20 Thread Heiko Stuebner
Hi Eddie, Am Freitag, 20. Januar 2017, 15:10:47 CET schrieb Eddie Cai: > 2017-01-19 17:58 GMT+08:00 Heiko Stuebner : > > Hi Eddie, > > > > Am Donnerstag, 19. Januar 2017, 10:11:59 CET schrieb Eddie Cai: > >> This patch add basic support for RK3288-Tinker board. We can boot in to > >> rootfs with

Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-01-19 Thread Shawn Lin
On 2017/1/20 15:07, Eddie Cai wrote: 2017-01-20 10:29 GMT+08:00 Shawn Lin : On 2017/1/19 10:11, Eddie Cai wrote: This patch add basic support for RK3288-Tinker board. We can boot in to rootfs with this patch. Signed-off-by: Eddie Cai --- arch/arm/boot/dts/Makefile | 1 + arch/ar

Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-01-19 Thread Eddie Cai
2017-01-20 10:29 GMT+08:00 Shawn Lin : > > On 2017/1/19 10:11, Eddie Cai wrote: >> >> This patch add basic support for RK3288-Tinker board. We can boot in to >> rootfs >> with this patch. >> >> Signed-off-by: Eddie Cai >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/r

Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-01-19 Thread Eddie Cai
2017-01-19 17:58 GMT+08:00 Heiko Stuebner : > Hi Eddie, > > Am Donnerstag, 19. Januar 2017, 10:11:59 CET schrieb Eddie Cai: >> This patch add basic support for RK3288-Tinker board. We can boot in to >> rootfs with this patch. >> >> Signed-off-by: Eddie Cai > > looks good in general, just some smal

Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-01-19 Thread Shawn Lin
On 2017/1/19 10:11, Eddie Cai wrote: This patch add basic support for RK3288-Tinker board. We can boot in to rootfs with this patch. Signed-off-by: Eddie Cai --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/rk3288-tinker.dts | 556 2 files

Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-01-19 Thread Heiko Stuebner
Hi Eddie, Am Donnerstag, 19. Januar 2017, 10:11:59 CET schrieb Eddie Cai: > This patch add basic support for RK3288-Tinker board. We can boot in to > rootfs with this patch. > > Signed-off-by: Eddie Cai looks good in general, just some small question down below. [...] > + /* > + * NO

[PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-01-18 Thread Eddie Cai
This patch add basic support for RK3288-Tinker board. We can boot in to rootfs with this patch. Signed-off-by: Eddie Cai --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/rk3288-tinker.dts | 556 2 files changed, 557 insertions(+) create mod