On Monday 28 July 2014 13:17:56 Benoit Masson wrote:
>
> Ok then does this mean I can simply remove the "compatible" line to only
> inherits from armada-xp-dtsi ?
>
> "i2c@11000 {
> clock-frequency = <40>;
> status = "okay";
> "
Le 28 juil. 2014 à 13:02, Arnd Bergmann a écrit :
> On Monday 28 July 2014 12:50:47 Benoit Masson wrote:
>>>
>>> It should still list both "marvell,mv78230-i2c" and "marvell,mv64xxx-i2c",
>>> as the generic name may not be enough to describe the register layout
>>> correctly.
>>
>> I tend to d
On Monday 28 July 2014 12:50:47 Benoit Masson wrote:
> >
> > It should still list both "marvell,mv78230-i2c" and "marvell,mv64xxx-i2c",
> > as the generic name may not be enough to describe the register layout
> > correctly.
>
> I tend to disagree since the dts include the armada-xp.dtsi, which a
Le 28 juil. 2014 à 10:49, Arnd Bergmann a écrit :
> On Sunday 27 July 2014 03:52:44 Andrew Lunn wrote:
>> Hi Benoit
Hi Arnd,
>>
>>> + i2c@11000 {
>>> + compatible = "marvell,mv78230-a0-i2c",
>>> + "marvell,mv6
On Sunday 27 July 2014 03:52:44 Andrew Lunn wrote:
> Hi Benoit
>
> > + i2c@11000 {
> > + compatible = "marvell,mv78230-a0-i2c",
> > + "marvell,mv64xxx-i2c";
>
> The point of my patches is that you don't need the
>
Hi Benoit
> + i2c@11000 {
> + compatible = "marvell,mv78230-a0-i2c",
> + "marvell,mv64xxx-i2c";
The point of my patches is that you don't need the
"marvell,mv78230-a0-i2c". It will work out at runtime if the SoC i
The Lenovo Iomega ix4-300d is a 4-Bay sata NAS with dual Gb,
USB2.0 & 3.0, powered by a Marvell Armada XP MV78230 dual core CPU.
http://shop.lenovo.com/us/en/servers/network-storage/lenovoemc/ix4-300d/
Signed-off-by: Benoit Masson
---
arch/arm/boot/dts/Makefile | 3 +-
a
On Thu, Jul 24, 2014 at 04:29:18PM +0200, Andrew Lunn wrote:
> > The only outstanding point (Arnd?), is that I think it's ok to have the
> > i2c...a0 compatible string in the dts files, but Andrew seems to think
> > otherwise. Is that still true Andrew?
>
> Hi Jason
>
> I can live with i2c...a0
> The only outstanding point (Arnd?), is that I think it's ok to have the
> i2c...a0 compatible string in the dts files, but Andrew seems to think
> otherwise. Is that still true Andrew?
Hi Jason
I can live with i2c...a0 compatible string, but it has minor problems:
1) The binding Documentation
Benoit,
Please try to avoid top-posting. I've re-flowed it, below.
Arnd, Andrew, question for both of you below.
On Thu, Jul 24, 2014 at 03:40:42PM +0200, Benoit Masson wrote:
> Le 24 juil. 2014 à 14:45, Jason Cooper a écrit :
>
> > On Thu, Jul 24, 2014 at 02:21:03PM +0200, Gregory CLEMENT wr
> > Well about the issue, we patch the device tree for the i2c quirk only for
> > the openblock AX3.
>
> Ahhh, that's right. I need to slow down and dig a bit more. :(
>
> > If I remember well it was because the device tree was already written
> > for this board before we found there was an issu
On Thu, Jul 24, 2014 at 02:21:03PM +0200, Gregory CLEMENT wrote:
> On 24/07/2014 01:15, Jason Cooper wrote:
> > On Thu, Jul 24, 2014 at 01:11:12AM +0200, Benoit Masson wrote:
> >> Le 24 juil. 2014 à 00:58, Andrew Lunn a écrit :
> >>
> For the marvell,mv78230-a0-i2c unfortunately i've spend 3
On 24/07/2014 01:15, Jason Cooper wrote:
> On Thu, Jul 24, 2014 at 01:11:12AM +0200, Benoit Masson wrote:
>> Le 24 juil. 2014 à 00:58, Andrew Lunn a écrit :
>>
For the marvell,mv78230-a0-i2c unfortunately i've spend 3 hours
trying to understand this but it only works with this on the
>>>
Benoit,
> On Thu, Jul 24, 2014 at 01:29:09AM +0200, Andrew Lunn wrote:
> >
> > We should not really leave the i2c compatibility string as it is.
> >
If you were to apply
ed2d859119f9 ARM: mvebu: Fix broken SoC ID detection
And then remove the -a0 i2c compatible string, does your board boot?
Hi Benoit,
On Wed, Jul 23, 2014 at 03:52:53PM -0700, Benoit Masson wrote:
> The Lenovo Iomega ix4-300d is a 4-Bay sata NAS with dual Gb,
> USB2.0 & 3.0, powered by a Marvell Armada XP MV78230 dual core CPU.
>
> http://shop.lenovo.com/fr/fr/servers/network-storage/lenovoemc/ix4-300d/
I guess mos
On Thu, Jul 24, 2014 at 01:29:09AM +0200, Andrew Lunn wrote:
> > On Wed, Jul 23, 2014 at 03:52:53PM -0700, Benoit Masson wrote:
> > > The Lenovo Iomega ix4-300d is a 4-Bay sata NAS with dual Gb,
> > > USB2.0 & 3.0, powered by a Marvell Armada XP MV78230 dual core CPU.
> > >
> > > http://shop.leno
> On Wed, Jul 23, 2014 at 03:52:53PM -0700, Benoit Masson wrote:
> > The Lenovo Iomega ix4-300d is a 4-Bay sata NAS with dual Gb,
> > USB2.0 & 3.0, powered by a Marvell Armada XP MV78230 dual core CPU.
> >
> > http://shop.lenovo.com/fr/fr/servers/network-storage/lenovoemc/ix4-300d/
> > Signed-off
Benoit,
This looks a lot better, thanks for turning it around so quickly!
My only general comment is just for the future. When submitting new
versions of patches, please add a 'V2' inside the brackets on the
Subject line. Or v3, or v4, or v14 in rare cases ;-)
It really helps us patch wrangler
On Thu, Jul 24, 2014 at 01:11:12AM +0200, Benoit Masson wrote:
> Le 24 juil. 2014 à 00:58, Andrew Lunn a écrit :
>
> >> For the marvell,mv78230-a0-i2c unfortunately i've spend 3 hours
> >> trying to understand this but it only works with this on the
> >> ix4-300d :(. There was multiple patch arou
> For the marvell,mv78230-a0-i2c unfortunately i've spend 3 hours
> trying to understand this but it only works with this on the
> ix4-300d :(. There was multiple patch around this and maybe one
> broke the auto-detect part of this, I've tried compiling with some
> 3.10 or lower kernel but no luck
No worries, sorry it makes more email for you guys, I've added the colors for
power and revert order hdd:blue instead of blue:hdd for the hdd led.
For the marvell,mv78230-a0-i2c unfortunately i've spend 3 hours trying to
understand this but it only works with this on the ix4-300d :(. There was
The Lenovo Iomega ix4-300d is a 4-Bay sata NAS with dual Gb,
USB2.0 & 3.0, powered by a Marvell Armada XP MV78230 dual core CPU.
http://shop.lenovo.com/fr/fr/servers/network-storage/lenovoemc/ix4-300d/
Signed-off-by: Benoit Masson
---
arch/arm/boot/dts/Makefile | 3 +-
ar
> + i2c@11000 {
> + compatible = "marvell,mv78230-a0-i2c",
> + "marvell,mv64xxx-i2c";
Ah sorry, i missed this first time. Do you really need
"marvell,mv78230-a0-i2c"?
Documentation/devicetree/bindings/i2c/i2c-mv64
The Lenovo Iomega ix4-300d is a 4-Bay sata NAS with dual Gb,
USB2.0 & 3.0, powered by a Marvell Armada XP MV78230 dual core CPU.
http://shop.lenovo.com/fr/fr/servers/network-storage/lenovoemc/ix4-300d/
Signed-off-by: Benoit Masson
---
arch/arm/boot/dts/Makefile | 3 +-
ar
24 matches
Mail list logo
