Re: [PATCH 2/2] ASoC: add tda7419 audio processor driver

On Fri, Mar 09, 2018 at 03:29:12PM +, Mark Brown wrote: > On Fri, Mar 09, 2018 at 09:35:48AM -0500, Matt Porter wrote: > > On Wed, Feb 28, 2018 at 11:00:38AM +, Mark Brown wrote: > > > On Tue, Feb 27, 2018 at 05:51:28PM -0500, Matt Porter wrote: > > > > > +static struct snd_kcontrol_new

Re: [PATCH 2/2] ASoC: add tda7419 audio processor driver

On Fri, Mar 09, 2018 at 03:29:12PM +, Mark Brown wrote: > On Fri, Mar 09, 2018 at 09:35:48AM -0500, Matt Porter wrote: > > On Wed, Feb 28, 2018 at 11:00:38AM +, Mark Brown wrote: > > > On Tue, Feb 27, 2018 at 05:51:28PM -0500, Matt Porter wrote: > > > > > +static struct snd_kcontrol_new

Re: [PATCH 2/2] ASoC: add tda7419 audio processor driver

On Fri, Mar 09, 2018 at 09:35:48AM -0500, Matt Porter wrote: > On Wed, Feb 28, 2018 at 11:00:38AM +, Mark Brown wrote: > > On Tue, Feb 27, 2018 at 05:51:28PM -0500, Matt Porter wrote: > > > +static struct snd_kcontrol_new tda7419_controls[] = { > > > +SOC_ENUM("Main Source Select",

Re: [PATCH 2/2] ASoC: add tda7419 audio processor driver

On Fri, Mar 09, 2018 at 09:35:48AM -0500, Matt Porter wrote: > On Wed, Feb 28, 2018 at 11:00:38AM +, Mark Brown wrote: > > On Tue, Feb 27, 2018 at 05:51:28PM -0500, Matt Porter wrote: > > > +static struct snd_kcontrol_new tda7419_controls[] = { > > > +SOC_ENUM("Main Source Select",

Re: [PATCH 2/2] ASoC: add tda7419 audio processor driver

On Wed, Feb 28, 2018 at 11:00:38AM +, Mark Brown wrote: > On Tue, Feb 27, 2018 at 05:51:28PM -0500, Matt Porter wrote: > > > +static bool tda7419_writeable_reg(struct device *dev, unsigned int reg) > > +{ > > + return true; > > +} > > This is the default behaviour, may as well omit it (but

Re: [PATCH 2/2] ASoC: add tda7419 audio processor driver

On Wed, Feb 28, 2018 at 11:00:38AM +, Mark Brown wrote: > On Tue, Feb 27, 2018 at 05:51:28PM -0500, Matt Porter wrote: > > > +static bool tda7419_writeable_reg(struct device *dev, unsigned int reg) > > +{ > > + return true; > > +} > > This is the default behaviour, may as well omit it (but

Re: [PATCH 2/2] ASoC: add tda7419 audio processor driver

Hi Matt, I love your patch! Perhaps something to improve: [auto build test WARNING on asoc/for-next] [also build test WARNING on v4.16-rc3 next-20180302] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] ASoC: add tda7419 audio processor driver

Hi Matt, I love your patch! Perhaps something to improve: [auto build test WARNING on asoc/for-next] [also build test WARNING on v4.16-rc3 next-20180302] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] ASoC: add tda7419 audio processor driver

On Tue, Feb 27, 2018 at 05:51:28PM -0500, Matt Porter wrote: > +static bool tda7419_writeable_reg(struct device *dev, unsigned int reg) > +{ > + return true; > +} This is the default behaviour, may as well omit it (but equally it does no harm). > +static inline int tda7419_vol_get_value(int

Re: [PATCH 2/2] ASoC: add tda7419 audio processor driver

On Tue, Feb 27, 2018 at 05:51:28PM -0500, Matt Porter wrote: > +static bool tda7419_writeable_reg(struct device *dev, unsigned int reg) > +{ > + return true; > +} This is the default behaviour, may as well omit it (but equally it does no harm). > +static inline int tda7419_vol_get_value(int

[PATCH 2/2] ASoC: add tda7419 audio processor driver

Component driver for the tda7419 audio processor. Signed-off-by: Matt Porter --- sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tda7419.c | 571 + 3 files changed, 579 insertions(+)

[PATCH 2/2] ASoC: add tda7419 audio processor driver

Component driver for the tda7419 audio processor. Signed-off-by: Matt Porter --- sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tda7419.c | 571 + 3 files changed, 579 insertions(+) create mode 100644