Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-16 Thread Wu, Songjun
On 9/17/2015 03:42, Mark Brown wrote: On Tue, Sep 15, 2015 at 11:11:53AM +0800, Wu, Songjun wrote: I try to use one entry, but there is a problem. It's about 'driver_data' in struct device. In function snd_soc_register_card, the parameter 'card' will be set to 'driver_data' by the code

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-16 Thread Mark Brown
On Tue, Sep 15, 2015 at 11:11:53AM +0800, Wu, Songjun wrote: > I try to use one entry, but there is a problem. > It's about 'driver_data' in struct device. > In function snd_soc_register_card, the parameter 'card' will be set to > 'driver_data' by the code 'dev_set_drvdata(card->dev, card)'. >

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-16 Thread Wu, Songjun
On 9/17/2015 03:42, Mark Brown wrote: On Tue, Sep 15, 2015 at 11:11:53AM +0800, Wu, Songjun wrote: I try to use one entry, but there is a problem. It's about 'driver_data' in struct device. In function snd_soc_register_card, the parameter 'card' will be set to 'driver_data' by the code

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-16 Thread Mark Brown
On Tue, Sep 15, 2015 at 11:11:53AM +0800, Wu, Songjun wrote: > I try to use one entry, but there is a problem. > It's about 'driver_data' in struct device. > In function snd_soc_register_card, the parameter 'card' will be set to > 'driver_data' by the code 'dev_set_drvdata(card->dev, card)'. >

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-14 Thread Wu, Songjun
On 9/8/2015 20:23, Mark Brown wrote: On Tue, Sep 08, 2015 at 05:36:13PM +0800, Wu, Songjun wrote: On 9/8/2015 00:25, Mark Brown wrote: Sure, there's no problem at all having that structure in software but it should be possible to do this without having to represent this structure in DT.

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-14 Thread Wu, Songjun
On 9/8/2015 20:23, Mark Brown wrote: On Tue, Sep 08, 2015 at 05:36:13PM +0800, Wu, Songjun wrote: On 9/8/2015 00:25, Mark Brown wrote: Sure, there's no problem at all having that structure in software but it should be possible to do this without having to represent this structure in DT.

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-08 Thread Wu, Songjun
On 9/8/2015 20:23, Mark Brown wrote: On Tue, Sep 08, 2015 at 05:36:13PM +0800, Wu, Songjun wrote: On 9/8/2015 00:25, Mark Brown wrote: Sure, there's no problem at all having that structure in software but it should be possible to do this without having to represent this structure in DT.

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-08 Thread Mark Brown
On Tue, Sep 08, 2015 at 05:36:13PM +0800, Wu, Songjun wrote: > On 9/8/2015 00:25, Mark Brown wrote: > >Sure, there's no problem at all having that structure in software but it > >should be possible to do this without having to represent this structure > >in DT. It should be possible to register

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-08 Thread Wu, Songjun
On 9/8/2015 00:25, Mark Brown wrote: On Sun, Sep 06, 2015 at 05:44:30PM +0800, Wu, Songjun wrote: On 9/3/2015 19:43, Mark Brown wrote: Why is this a separate DT node? It seems that this IP is entirely self contained so I'm not clear why we need a separate node for the card, the card is

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-08 Thread Wu, Songjun
On 9/8/2015 00:25, Mark Brown wrote: On Sun, Sep 06, 2015 at 05:44:30PM +0800, Wu, Songjun wrote: On 9/3/2015 19:43, Mark Brown wrote: Why is this a separate DT node? It seems that this IP is entirely self contained so I'm not clear why we need a separate node for the card, the card is

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-08 Thread Mark Brown
On Tue, Sep 08, 2015 at 05:36:13PM +0800, Wu, Songjun wrote: > On 9/8/2015 00:25, Mark Brown wrote: > >Sure, there's no problem at all having that structure in software but it > >should be possible to do this without having to represent this structure > >in DT. It should be possible to register

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-08 Thread Wu, Songjun
On 9/8/2015 20:23, Mark Brown wrote: On Tue, Sep 08, 2015 at 05:36:13PM +0800, Wu, Songjun wrote: On 9/8/2015 00:25, Mark Brown wrote: Sure, there's no problem at all having that structure in software but it should be possible to do this without having to represent this structure in DT.

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-07 Thread Mark Brown
On Sun, Sep 06, 2015 at 05:44:30PM +0800, Wu, Songjun wrote: > On 9/3/2015 19:43, Mark Brown wrote: > >Why is this a separate DT node? It seems that this IP is entirely self > >contained so I'm not clear why we need a separate node for the card, the > >card is usually a separate node because it

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-07 Thread Mark Brown
On Sun, Sep 06, 2015 at 05:44:30PM +0800, Wu, Songjun wrote: > On 9/3/2015 19:43, Mark Brown wrote: > >Why is this a separate DT node? It seems that this IP is entirely self > >contained so I'm not clear why we need a separate node for the card, the > >card is usually a separate node because it

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-06 Thread Wu, Songjun
On 9/3/2015 19:43, Mark Brown wrote: On Tue, Sep 01, 2015 at 01:41:41PM +0800, Songjun Wu wrote: +classd: classd@fc048000 { + compatible = "atmel,sama5d2-classd"; + reg = <0xfc048000 0x100>; + interrupts = <59 IRQ_TYPE_LEVEL_HIGH 7>; +

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-06 Thread Wu, Songjun
On 9/3/2015 19:43, Mark Brown wrote: On Tue, Sep 01, 2015 at 01:41:41PM +0800, Songjun Wu wrote: +classd: classd@fc048000 { + compatible = "atmel,sama5d2-classd"; + reg = <0xfc048000 0x100>; + interrupts = <59 IRQ_TYPE_LEVEL_HIGH 7>; +

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-03 Thread Mark Brown
On Tue, Sep 01, 2015 at 01:41:41PM +0800, Songjun Wu wrote: > +classd: classd@fc048000 { > + compatible = "atmel,sama5d2-classd"; > + reg = <0xfc048000 0x100>; > + interrupts = <59 IRQ_TYPE_LEVEL_HIGH 7>; > + dmas = < > +

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-03 Thread Mark Brown
On Tue, Sep 01, 2015 at 01:41:41PM +0800, Songjun Wu wrote: > +classd: classd@fc048000 { > + compatible = "atmel,sama5d2-classd"; > + reg = <0xfc048000 0x100>; > + interrupts = <59 IRQ_TYPE_LEVEL_HIGH 7>; > + dmas = < > +

[PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-08-31 Thread Songjun Wu
DT binding documentation for this new ASoC driver. Signed-off-by: Songjun Wu --- .../devicetree/bindings/sound/atmel-classd.txt | 73 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/atmel-classd.txt diff --git

[PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-08-31 Thread Songjun Wu
DT binding documentation for this new ASoC driver. Signed-off-by: Songjun Wu --- .../devicetree/bindings/sound/atmel-classd.txt | 73 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/atmel-classd.txt