Re: [PATCH 2/2] ASoC: fsl_mqs: Add MQS component driver

2019-09-11 Thread Mark Brown
On Wed, Sep 11, 2019 at 10:42:39AM -0400, Shengjiu Wang wrote: This looks good, a few minor comments below but nothing major - it's mostly nits with the DT binding. > --- /dev/null > +++ b/sound/soc/fsl/fsl_mqs.c > @@ -0,0 +1,336 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * ALSA SoC IMX

[PATCH 2/2] ASoC: fsl_mqs: Add MQS component driver

2019-09-10 Thread Shengjiu Wang
MQS (medium quality sound), is used to generate medium quality audio via a standard digital output pin. It can be used to connect stereo speakers or headphones simply via power amplifier stages without an additional DAC chip. It only accepts 2-channel, LSB-valid 16bit, MSB shift-out first, frame