Re: [PATCH 2/2] ASoC: hisilicon: Minor fixups to hi6210 i2s audio driver

2017-04-11 Thread John Stultz
On Tue, Apr 11, 2017 at 11:34 AM, Mark Brown wrote: > On Mon, Apr 10, 2017 at 12:35:12PM -0700, John Stultz wrote: > >> This patch adds a few extra error returns in cases that >> shouldn't happen, some style nits adding breaks to final >> default cases in switch statements, and tweaks to use >> de

Re: [PATCH 2/2] ASoC: hisilicon: Minor fixups to hi6210 i2s audio driver

2017-04-11 Thread Mark Brown
On Mon, Apr 10, 2017 at 12:35:12PM -0700, John Stultz wrote: > This patch adds a few extra error returns in cases that > shouldn't happen, some style nits adding breaks to final > default cases in switch statements, and tweaks to use > devm_ variant of snd_soc_register_component. Please don't mak

[PATCH 2/2] ASoC: hisilicon: Minor fixups to hi6210 i2s audio driver

2017-04-10 Thread John Stultz
Mark had a few minor fixups he requested to the hi6210 i2s driver, so this patch proves them. This patch adds a few extra error returns in cases that shouldn't happen, some style nits adding breaks to final default cases in switch statements, and tweaks to use devm_ variant of snd_soc_register_com