On Fri, May 29, 2020 at 6:35 PM Mark Brown wrote:
>
> On Fri, May 29, 2020 at 05:04:36PM +0900, Steve Lee wrote:
> > On Thu, May 28, 2020 at 8:54 PM Mark Brown wrote:
>
> > > > Reported-by: kbuild test robot
>
> > > Don't think the lkp bot asked for this driver! :P
>
> > Thanks, I will send
On Fri, May 29, 2020 at 05:04:36PM +0900, Steve Lee wrote:
> On Thu, May 28, 2020 at 8:54 PM Mark Brown wrote:
> > > Reported-by: kbuild test robot
> > Don't think the lkp bot asked for this driver! :P
> Thanks, I will send split patch for this.
No, just don't add the line when it's a new
On Thu, May 28, 2020 at 8:54 PM Mark Brown wrote:
>
> On Thu, May 28, 2020 at 07:39:42PM +0900, Steve Lee wrote:
> > This is the initial amplifier driver for max98390.
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code.
On Thu, May 28, 2020 at 07:39:42PM +0900, Steve Lee wrote:
> This is the initial amplifier driver for max98390.
Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code. Modifying existing
commits creates problems for other users
This is the initial amplifier driver for max98390.
Reported-by: kbuild test robot
Signed-off-by: Steve Lee
---
Changes since V5:
* Fixed warning message reported by kbuild.
* Finalize default register value.
* Update missed AMP_EN register setting during dsm_init.
Hi Steve,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on v5.7-rc6 next-20200515]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base'
This is the initial amplifier driver for max98390.
Signed-off-by: Steve Lee
---
Changes since V4:
* Revert return calibration status in max98390_dsm_calib_get:
There is no need to return calibration status in get function
because there is mixer control
On Fri, May 15, 2020 at 9:29 PM Mark Brown wrote:
>
> On Fri, May 15, 2020 at 10:42:24AM +0200, Krzysztof Kozlowski wrote:
>
> > Your "From" address still does not match the Signed-off-by. Set the
> > author of commit to the signed-off person.
>
> git commit --amend --author='foo '
Thanks. I
On Fri, May 15, 2020 at 10:42:24AM +0200, Krzysztof Kozlowski wrote:
> Your "From" address still does not match the Signed-off-by. Set the
> author of commit to the signed-off person.
git commit --amend --author='foo '
signature.asc
Description: PGP signature
On Fri, 15 May 2020 at 09:08, Steve Lee wrote:
>
> This is the initial amplifier driver for max98390.
>
> Signed-off-by: Steve Lee
Hi,
Your "From" address still does not match the Signed-off-by. Set the
author of commit to the signed-off person.
Best regards,
Krzysztof
This is the initial amplifier driver for max98390.
Signed-off-by: Steve Lee
---
Changes since V4:
* Revert return calibration status in max98390_dsm_calib_get:
There is no need to return calibration status in get function
because there is mixer control
This is the initial amplifier driver for max98390.
Signed-off-by: Steve Lee
---
Changes since V3:
* Add operation at max98390_dsm_calib_get:
Add cal_running variable at max98390_priv structure
Add return cal_running at max98390_dsm_calib_get
On Thu, May 14, 2020 at 7:17 PM Mark Brown wrote:
>
> On Wed, May 13, 2020 at 07:58:12PM +0800, Tzung-Bi Shih wrote:
> > On Wed, May 13, 2020 at 6:53 PM Mark Brown wrote:
> > > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:
>
> > > > Changes since V2:
> > > > * Removed warn
On Wed, May 13, 2020 at 07:58:12PM +0800, Tzung-Bi Shih wrote:
> On Wed, May 13, 2020 at 6:53 PM Mark Brown wrote:
> > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:
> > > Changes since V2:
> > > * Removed warn massage in max98390_dsm_calib_get func
> > > and add
On Thu, May 14, 2020 at 03:31:52PM +0800, Tzung-Bi Shih wrote:
> On Wed, May 13, 2020 at 3:47 PM Steve Lee wrote:
> > +++ b/sound/soc/codecs/max98390.c
> > @@ -0,0 +1,1030 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > + * max98390.c -- MAX98390 ALSA Soc Audio driver
> > + *
>
On Wed, May 13, 2020 at 3:47 PM Steve Lee wrote:
> +++ b/sound/soc/codecs/max98390.c
> @@ -0,0 +1,1030 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * max98390.c -- MAX98390 ALSA Soc Audio driver
> + *
> + * Copyright (C) 2020 Maxim Integrated Products
> + *
> + */
My previous
On Wed, May 13, 2020 at 6:53 PM Mark Brown wrote:
>
> On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:
>
> > Changes since V2:
> > * Removed warn massage in max98390_dsm_calib_get func
> > and add comment.
>
> The problem isn't the warning, the problem is that you have an
On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:
> Changes since V2:
> * Removed warn massage in max98390_dsm_calib_get func
> and add comment.
The problem isn't the warning, the problem is that you have an empty
operation. You should either implement the function (eg,
This is the initial amplifier driver for max98390.
Signed-off-by: Steve Lee
---
Changes since V2:
* Removed warn massage in max98390_dsm_calib_get func
and add comment.
Changes since v1:
* Updated according to Mark's comments.
* Updated according to Tzung-Bi's
On Tue, May 12, 2020 at 7:33 PM Mark Brown wrote:
>
> On Tue, May 12, 2020 at 06:13:05PM +0900, Steve Lee wrote:
> > On Mon, May 11, 2020 at 8:03 PM Mark Brown wrote:
>
> > > > +static const char * const max98390_current_limit_text[] = {
> > > > + "0.00A", "0.50A", "1.00A", "1.05A", "1.10A",
On Tue, May 12, 2020 at 06:13:05PM +0900, Steve Lee wrote:
> On Mon, May 11, 2020 at 8:03 PM Mark Brown wrote:
> > > +static const char * const max98390_current_limit_text[] = {
> > > + "0.00A", "0.50A", "1.00A", "1.05A", "1.10A", "1.15A", "1.20A",
> > > "1.25A",
> > > + "1.30A",
This is the initial amplifier driver for max98390.
Signed-off-by: Steve Lee
---
Changes since v1:
* updated according to Mark's comments.
* updated according to Tzung-Bi's comments.
* Removed Enum structure and use TLV data for Volume control
sound/soc/codecs/Kconfig
On Mon, May 11, 2020 at 8:16 PM Tzung-Bi Shih wrote:
>
> (The patch passed 2 round review in https://crrev.com/c/2083354)
>
> On Sun, May 10, 2020 at 4:23 PM Steve Lee wrote:
> > +static int max98390_dai_set_fmt(struct snd_soc_dai *codec_dai, unsigned
> > int fmt)
> > +{
> > + struct
On Mon, May 11, 2020 at 8:03 PM Mark Brown wrote:
>
> On Sat, May 09, 2020 at 12:19:19PM +0900, Steve Lee wrote:
> > Signed-off-by: Steve Lee
>
> This looks mostly good, a few smallish things below though:
>
> > +++ b/sound/soc/codecs/max98390.c
> > @@ -0,0 +1,1039 @@
> > +//
(The patch passed 2 round review in https://crrev.com/c/2083354)
On Sun, May 10, 2020 at 4:23 PM Steve Lee wrote:
> +static int max98390_dai_set_fmt(struct snd_soc_dai *codec_dai, unsigned int
> fmt)
> +{
> + struct snd_soc_component *component = codec_dai->component;
> + struct
On Sat, May 09, 2020 at 12:19:19PM +0900, Steve Lee wrote:
> Signed-off-by: Steve Lee
This looks mostly good, a few smallish things below though:
> +++ b/sound/soc/codecs/max98390.c
> @@ -0,0 +1,1039 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2020, Maxim Integrated.
> +
Signed-off-by: Steve Lee
---
sound/soc/codecs/Kconfig|5 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/max98390.c | 1039 +++
sound/soc/codecs/max98390.h | 661 ++
4 files changed, 1707 insertions(+)
create mode 100644
27 matches
Mail list logo
