Re: [PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650 codec

2015-07-17 Thread zhengxing
Hi Mark, On 2015年07月18日 02:11, Mark Brown wrote: On Wed, Jul 15, 2015 at 11:15:43AM +0800, Xing Zheng wrote: From: zhengxing The driver is used for rockchip board using a rt5645/rt5650. Same comments here, mostly good but some minor issues. The other thing with both of these is that you need

Re: [PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650 codec

2015-07-17 Thread Mark Brown
On Wed, Jul 15, 2015 at 11:15:43AM +0800, Xing Zheng wrote: > From: zhengxing > > The driver is used for rockchip board using a rt5645/rt5650. Same comments here, mostly good but some minor issues. The other thing with both of these is that you need to have a binding document for them. signat

[PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650 codec

2015-07-14 Thread Xing Zheng
From: zhengxing The driver is used for rockchip board using a rt5645/rt5650. Reviewed-by: Dylan Reid Signed-off-by: zhengxing --- sound/soc/rockchip/Kconfig |9 ++ sound/soc/rockchip/Makefile |2 + sound/soc/rockchip/rockchip_rt5645.c | 235 ++