Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-26 Thread Stefan Agner
On 20.07.2018 10:04, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Actually report the error codes from of_get_named_gpio() resp. > devm_gpio_request_one() upon trying to get the codec reset resp. sync > GPIOs which may as well just be a probe deferrals. > > Signed-off-by: Marcel Ziswiler

Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-23 Thread Mark Brown
On Sat, Jul 21, 2018 at 10:06:23AM +, Marcel Ziswiler wrote: > On Sat, 2018-07-21 at 10:56 +0100, Mark Brown wrote: > > > > > - dev_err(&pdev->dev, "no codec-sync GPIO > > > > > supplied\n"); > > > > > + ret = ac97->sync_gpio; > And here I assign ret with that return v

Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-21 Thread Dmitry Osipenko
On Saturday, 21 July 2018 15:03:57 MSK Dmitry Osipenko wrote: > On Saturday, 21 July 2018 14:55:21 MSK Marcel Ziswiler wrote: > > On Sat, 2018-07-21 at 14:17 +0300, Dmitry Osipenko wrote: > > > On Saturday, 21 July 2018 12:56:15 MSK Mark Brown wrote: > > > > On Fri, Jul 20, 2018 at 12:31:07PM +

Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-21 Thread Dmitry Osipenko
On Saturday, 21 July 2018 14:55:21 MSK Marcel Ziswiler wrote: > On Sat, 2018-07-21 at 14:17 +0300, Dmitry Osipenko wrote: > > > On Saturday, 21 July 2018 12:56:15 MSK Mark Brown wrote: > > > > > On Fri, Jul 20, 2018 at 12:31:07PM +, Marcel Ziswiler wrote: > > > > > > > On Fri, 2018-07-20 at

Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-21 Thread Marcel Ziswiler
On Sat, 2018-07-21 at 14:17 +0300, Dmitry Osipenko wrote: > On Saturday, 21 July 2018 12:56:15 MSK Mark Brown wrote: > > On Fri, Jul 20, 2018 at 12:31:07PM +, Marcel Ziswiler wrote: > > > On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote: > > > > > ac97->sync_gpio = of_get_named_gpio(pd

Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-21 Thread Dmitry Osipenko
On Saturday, 21 July 2018 12:56:15 MSK Mark Brown wrote: > On Fri, Jul 20, 2018 at 12:31:07PM +, Marcel Ziswiler wrote: > > On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote: > > > > ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node, > > > > > > > >

Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-21 Thread Marcel Ziswiler
On Sat, 2018-07-21 at 10:56 +0100, Mark Brown wrote: > On Fri, Jul 20, 2018 at 12:31:07PM +, Marcel Ziswiler wrote: > > On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote: > > > > ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node, > > > >

Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-21 Thread Mark Brown
On Fri, Jul 20, 2018 at 12:31:07PM +, Marcel Ziswiler wrote: > On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote: > > > ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node, > > > "nvidia,codec-sync- > > > gpio", 0); > > > if (!gpio_is_valid(ac97->s

Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-20 Thread Marcel Ziswiler
On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote: > On Fri, Jul 20, 2018 at 10:04:24AM +0200, Marcel Ziswiler wrote: > > > - dev_err(&pdev->dev, "could not get codec- > > reset GPIO\n"); > > + dev_err(&pdev->dev, "could not get codec- > > reset GPIO: " > > +

Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-20 Thread Mark Brown
On Fri, Jul 20, 2018 at 10:04:24AM +0200, Marcel Ziswiler wrote: > - dev_err(&pdev->dev, "could not get codec-reset GPIO\n"); > + dev_err(&pdev->dev, "could not get codec-reset GPIO: " > + "%d\n", ret); Don't split st

[PATCH 2/2] ASoC: tegra: probe deferral error reporting

2018-07-20 Thread Marcel Ziswiler
From: Marcel Ziswiler Actually report the error codes from of_get_named_gpio() resp. devm_gpio_request_one() upon trying to get the codec reset resp. sync GPIOs which may as well just be a probe deferrals. Signed-off-by: Marcel Ziswiler --- sound/soc/tegra/tegra20_ac97.c | 9 ++--- 1 fil