Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Curt Brune
On Thu Jan 23 19:15, Wolfram Sang wrote: > > > Well, it is not the Copyrights section, or you are saying the same > > people should go to MODULE_AUTHOR as in the Copyrights section, even > > if it is potentially several names? I thought this would be the name > > of the person who put the file tog

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Wolfram Sang
> Well, it is not the Copyrights section, or you are saying the same > people should go to MODULE_AUTHOR as in the Copyrights section, even > if it is potentially several names? I thought this would be the name > of the person who put the file together even if from existing sources. You may be ri

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Laszlo Papp
On Thu, Jan 23, 2014 at 5:25 PM, Wolfram Sang wrote: > Hi, > > No need to quote the whole message if you reply only to a bit of it. > >> > module_init(at24_init); >> > >> > static void __exit at24_exit(void) >> > { >> > i2c_del_driver(&at24_driver); >> > } >> > module_exit(at24_exit);

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Wolfram Sang
Hi, No need to quote the whole message if you reply only to a bit of it. > > module_init(at24_init); > > > > static void __exit at24_exit(void) > > { > > i2c_del_driver(&at24_driver); > > } > > module_exit(at24_exit); > > Couldn't you use module_i2c_driver() instead of this? He did

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Laszlo Papp
On Thu, Jan 23, 2014 at 3:05 PM, Curt Brune wrote: > On Thu Jan 23 07:44, Laszlo Papp wrote: >> On Wed, Jan 22, 2014 at 5:23 PM, Curt Brune wrote: >> > During device instantiation have the at24 driver add the new device to >> > the eeprom_dev hardware class. The functionality is enabled by >> >

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Curt Brune
On Thu Jan 23 07:44, Laszlo Papp wrote: > On Wed, Jan 22, 2014 at 5:23 PM, Curt Brune wrote: > > During device instantiation have the at24 driver add the new device to > > the eeprom_dev hardware class. The functionality is enabled by > > CONFIG_EEPROM_CLASS. [snip] > > static void __exit at24_e

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-22 Thread Laszlo Papp
On Wed, Jan 22, 2014 at 5:23 PM, Curt Brune wrote: > During device instantiation have the at24 driver add the new device to > the eeprom_dev hardware class. The functionality is enabled by > CONFIG_EEPROM_CLASS. > > Signed-off-by: Curt Brune > --- > drivers/misc/eeprom/at24.c | 20 +++