Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Jiri Slaby
Alan Cox napsal(a): > I think just using tty_wakeup for this ought to be sufficient unless they > are using the work queue for some kind of serialization of events Actually this is what I wanted to hear. Going to change those which does it. thanks, --js - To unsubscribe from this list: send the

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Alan Cox
On Thu, 1 Nov 2007 11:55:56 +0100 (CET) Jiri Slaby <[EMAIL PROTECTED]> wrote: > tty, add tty_schedule_wakeup > > Because several drivers schedule a workqueue only for tty_wakeup, move this > functionality into tty layer and use newly added centralized work. I've no idea why any drivers do

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Paul Fulghum
Jiri Slaby wrote: + * Functionally the same as tty_wakeup, but it can be used in hot + * paths. since the wakeup is scheduled and done in the future. I'm not familiar with the terminology 'hot paths', what do you mean by that? Do you have an example of where you intend to use this

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Jiri Slaby
Paul Fulghum napsal(a): > Jiri Slaby wrote: >> + *Functionally the same as tty_wakeup, but it can be used in hot >> + *paths. since the wakeup is scheduled and done in the future. >> > > I'm not familiar with the terminology 'hot paths', > what do you mean by that? Ah, thank you for the

[PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Jiri Slaby
UNTESTED so far -- tty, add tty_schedule_wakeup Because several drivers schedule a workqueue only for tty_wakeup, move this functionality into tty layer and use newly added centralized work. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> --- commit

[PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Jiri Slaby
UNTESTED so far -- tty, add tty_schedule_wakeup Because several drivers schedule a workqueue only for tty_wakeup, move this functionality into tty layer and use newly added centralized work. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] --- commit

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Jiri Slaby
Paul Fulghum napsal(a): Jiri Slaby wrote: + *Functionally the same as tty_wakeup, but it can be used in hot + *paths. since the wakeup is scheduled and done in the future. I'm not familiar with the terminology 'hot paths', what do you mean by that? Ah, thank you for the feedback,

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Paul Fulghum
Jiri Slaby wrote: + * Functionally the same as tty_wakeup, but it can be used in hot + * paths. since the wakeup is scheduled and done in the future. I'm not familiar with the terminology 'hot paths', what do you mean by that? Do you have an example of where you intend to use this

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Alan Cox
On Thu, 1 Nov 2007 11:55:56 +0100 (CET) Jiri Slaby [EMAIL PROTECTED] wrote: tty, add tty_schedule_wakeup Because several drivers schedule a workqueue only for tty_wakeup, move this functionality into tty layer and use newly added centralized work. I've no idea why any drivers do this. A

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Jiri Slaby
Alan Cox napsal(a): I think just using tty_wakeup for this ought to be sufficient unless they are using the work queue for some kind of serialization of events Actually this is what I wanted to hear. Going to change those which does it. thanks, --js - To unsubscribe from this list: send the