Re: [PATCH 2/2] Input: add MStar msg26xx touchscreen driver

2021-01-21 Thread Vincent Knecht
Hi Dmitry! Le mercredi 20 janvier 2021 à 23:03 -0800, Dmitry Torokhov a écrit : > Hi Vincent, > > On Wed, Jan 20, 2021 at 07:01:08PM +0100, Vincent Knecht wrote: > > +struct packet { > > +   u8  y_high : 4; > > +   u8  x_high : 4; > > This will not work on big endian devices as o

Re: [PATCH 2/2] Input: add MStar msg26xx touchscreen driver

2021-01-20 Thread Dmitry Torokhov
Hi Vincent, On Wed, Jan 20, 2021 at 07:01:08PM +0100, Vincent Knecht wrote: > +struct packet { > + u8 y_high : 4; > + u8 x_high : 4; This will not work on big endian devices as order of bitfields changes. I'd recommended treating contact packet as sequence of bytes and parse, i.

[PATCH 2/2] Input: add MStar msg26xx touchscreen driver

2021-01-20 Thread Vincent Knecht
Add support for the msg26xx touchscreen IC from MStar. This driver reuses zinitix.c structure, while the checksum and irq handler functions are based on out-of-tree driver for Alcatel Idol 3 (4.7"). Signed-off-by: Vincent Knecht --- drivers/input/touchscreen/Kconfig | 12 + drivers/input/touc