Re: [PATCH 2/2] Input: add driver for power button on Dell Wyse 3020

2020-05-07 Thread Dmitry Torokhov
On Thu, May 07, 2020 at 07:46:44PM +0200, Pavel Machek wrote: > Hi! > > > +struct ec_input_response { > > + u8 reserved; > > + u8 msg_counter:2; > > + u8 count:2; > > + u8 type:4; > > + u8 data[3]; > > +} __packed; > > Bitfields, and relying on them being in the right place for >

Re: [PATCH 2/2] Input: add driver for power button on Dell Wyse 3020

2020-05-07 Thread Pavel Machek
Hi! > +struct ec_input_response { > + u8 reserved; > + u8 msg_counter:2; > + u8 count:2; > + u8 type:4; > + u8 data[3]; > +} __packed; Bitfields, and relying on them being in the right place for communication with hardware. We don't usually do that, and there may be reasons

[PATCH 2/2] Input: add driver for power button on Dell Wyse 3020

2020-05-03 Thread Lubomir Rintel
This adds support for the power button attached to the Embedded Controller on a Dell Wyse 3020 "Ariel" board. The Embedded Controller's SPI interface is actually capable sending and receiving the PS/2 keyboard and mouse protocol data, which looks like a good fit for a serio driver. Howerver, I