Re: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes.

2020-07-17 Thread 'Dmitry Torokhov'
Hi Jingle, On Fri, Jul 17, 2020 at 04:31:58PM +0800, jingle wrote: > Hi Dmitry: > > 1. > > In this function elan_get_fwinfo(). > > +static int elan_get_fwinfo(u16 ic_type, u8 iap_version, u8 pattern, > +u16 *validpage_count, u32 *signature_address, > +

RE: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes.

2020-07-17 Thread jingle
#x27;Dmitry Torokhov' Cc: 'linux-kernel'; 'linux-input'; 'phoenix'; 'josh.chen'; 'kai.heng.feng' Subject: RE: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes. Hi Dmitry: In this "static i

RE: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes.

2020-07-17 Thread jingle
--- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Friday, July 17, 2020 2:10 PM To: jingle.wu Cc: linux-kernel; linux-input; phoenix; josh.chen; kai.heng.feng Subject: Re: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes. On Thu, Jul 16, 20

Re: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes.

2020-07-16 Thread Dmitry Torokhov
On Thu, Jul 16, 2020 at 06:27:19PM -0700, Dmitry Torokhov wrote: > Hi Jingle, > > On Thu, Jul 16, 2020 at 02:15:23PM +0800, jingle.wu wrote: > > HI Dmitry: > > > > Just to confirm, the older devices (I assume that pattern 0 means older) > > have version command that is numerically higher than th

Re: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes.

2020-07-16 Thread Dmitry Torokhov
Hi Jingle, On Thu, Jul 16, 2020 at 02:15:23PM +0800, jingle.wu wrote: > HI Dmitry: > > Just to confirm, the older devices (I assume that pattern 0 means older) > have version command that is numerically higher than the one for the > newer (pattern >= 1) devices? > > >> Yes, Pattern 1, 2 are ne

Re: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes.

2020-07-15 Thread jingle.wu
HI Dmitry: Just to confirm, the older devices (I assume that pattern 0 means older) have version command that is numerically higher than the one for the newer (pattern >= 1) devices? >> Yes, Pattern 1, 2 are newer devices. > @@ -324,7 +342,14 @@ static int elan_i2c_get_sm_version(struct i2c_cl