Re: [PATCH 2/2] Input: misc: introduce palmas-pwrbutton

2014-08-19 Thread Nishanth Menon
Hi Dmitry On 08/19/2014 12:23 AM, Dmitry Torokhov wrote: Thanks for the review. [...] + +/** + * pwron_irq() - button press isr + * @irq: irq + * @palmas_pwron: pwron struct + */ +static irqreturn_t pwron_irq(int irq, void *palmas_pwron) +{ + struct palmas_pwron *pwron

Re: [PATCH 2/2] Input: misc: introduce palmas-pwrbutton

2014-08-19 Thread Nishanth Menon
Hi Dmitry On 08/19/2014 12:23 AM, Dmitry Torokhov wrote: Thanks for the review. [...] + +/** + * pwron_irq() - button press isr + * @irq: irq + * @palmas_pwron: pwron struct + */ +static irqreturn_t pwron_irq(int irq, void *palmas_pwron) +{ + struct palmas_pwron *pwron

Re: [PATCH 2/2] Input: misc: introduce palmas-pwrbutton

2014-08-18 Thread Dmitry Torokhov
Hi NIshanth, On Mon, Aug 18, 2014 at 03:13:30PM -0500, Nishanth Menon wrote: > Many palmas family of PMICs have support for interrupt based power > button. This allows the device to notify the processor of external > push button events over the shared palmas interrupt. However, this > event is

[PATCH 2/2] Input: misc: introduce palmas-pwrbutton

2014-08-18 Thread Nishanth Menon
Many palmas family of PMICs have support for interrupt based power button. This allows the device to notify the processor of external push button events over the shared palmas interrupt. However, this event is generated only during a "press" operation. Software is supposed to poll(sigh!) for

[PATCH 2/2] Input: misc: introduce palmas-pwrbutton

2014-08-18 Thread Nishanth Menon
Many palmas family of PMICs have support for interrupt based power button. This allows the device to notify the processor of external push button events over the shared palmas interrupt. However, this event is generated only during a press operation. Software is supposed to poll(sigh!) for

Re: [PATCH 2/2] Input: misc: introduce palmas-pwrbutton

2014-08-18 Thread Dmitry Torokhov
Hi NIshanth, On Mon, Aug 18, 2014 at 03:13:30PM -0500, Nishanth Menon wrote: Many palmas family of PMICs have support for interrupt based power button. This allows the device to notify the processor of external push button events over the shared palmas interrupt. However, this event is