Re: [PATCH 2/2] KVM: SVM: Add support for MPK feature on AMD

2020-05-07 Thread Paolo Bonzini
On 07/05/20 00:26, Sean Christopherson wrote: >> +/* Load the guest pkru state */ >> +if (static_cpu_has(X86_FEATURE_PKU) && >> +kvm_read_cr4_bits(vcpu, X86_CR4_PKE) && >> +vcpu->arch.pkru != svm->host_pkru) >> +__write_pkru(vcpu->arch.pkru); > This and the resto

Re: [PATCH 2/2] KVM: SVM: Add support for MPK feature on AMD

2020-05-06 Thread Dave Hansen
On 5/6/20 3:02 PM, Babu Moger wrote: > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -818,6 +818,10 @@ static __init void svm_set_cpu_caps(void) > if (boot_cpu_has(X86_FEATURE_LS_CFG_SSBD) || > boot_cpu_has(X86_FEATURE_AMD_SSBD)) > kvm_cpu_cap_set(X8

Re: [PATCH 2/2] KVM: SVM: Add support for MPK feature on AMD

2020-05-06 Thread Sean Christopherson
On Wed, May 06, 2020 at 05:02:21PM -0500, Babu Moger wrote: > static __init int svm_hardware_setup(void) > @@ -1300,6 +1304,8 @@ static void svm_vcpu_load(struct kvm_vcpu *vcpu, int > cpu) > indirect_branch_prediction_barrier(); > } > avic_vcpu_load(vcpu, cpu); > + > +

[PATCH 2/2] KVM: SVM: Add support for MPK feature on AMD

2020-05-06 Thread Babu Moger
The Memory Protection Key (MPK) feature provides a way for applications to impose page-based data access protections (read/write, read-only or no access), without requiring modification of page tables and subsequent TLB invalidations when the application changes protection domains. This feature is