Re: [PATCH 2/2] PCI: generic: add description of property "interrupt-skip-mask"

2016-02-26 Thread Mark Rutland
On Fri, Feb 26, 2016 at 03:19:55PM +0800, Leizhen (ThunderTown) wrote: > > On 2016/2/25 20:20, Mark Rutland wrote: > > Hi, > > > > In future, please send the binding document first in a series, per point > > 3 of Documentation/devicetree/bindings/submitting-patches.txt. It makes > > review easier

Re: [PATCH 2/2] PCI: generic: add description of property "interrupt-skip-mask"

2016-02-25 Thread Leizhen (ThunderTown)
On 2016/2/25 20:20, Mark Rutland wrote: > Hi, > > In future, please send the binding document first in a series, per point > 3 of Documentation/devicetree/bindings/submitting-patches.txt. It makes > review easier/faster. Thank you for your reminding. > > On Thu, Feb 25, 2016 at 07:53:28PM +080

Re: [PATCH 2/2] PCI: generic: add description of property "interrupt-skip-mask"

2016-02-25 Thread Mark Rutland
Hi, In future, please send the binding document first in a series, per point 3 of Documentation/devicetree/bindings/submitting-patches.txt. It makes review easier/faster. On Thu, Feb 25, 2016 at 07:53:28PM +0800, Zhen Lei wrote: > Interrupt Pin register is read-only and optional. Some pci devices

[PATCH 2/2] PCI: generic: add description of property "interrupt-skip-mask"

2016-02-25 Thread Zhen Lei
Interrupt Pin register is read-only and optional. Some pci devices may use msi/msix but leave the value of Interrupt Pin non-zero. In this case, the driver will print information as below: pci :40:00.0: of_irq_parse_pci() failed with rc=-22 It's easily lead to misinterpret. Signed-off-by: Zhe