On Mon, May 11, 2015 at 11:04:39AM +0200, Martin Fuzzey wrote:
Please leave blank lines between paragraphs and between old text and new
text, it makes things a lot easier to read - this is extremely difficult
to follow.
> On 30/04/15 21:45, Mark Brown wrote:
> >On Tue, Apr 28, 2015 at 04:17:40PM
Thank you for the review.
On 30/04/15 21:45, Mark Brown wrote:
On Tue, Apr 28, 2015 at 04:17:40PM +0200, Martin Fuzzey wrote:
Signed-off-by: Martin Fuzzey
Please use subject lines reflecting the style for the subsystem.
You mean
regulator: mc34708: Add driver?
I ommitted the mc34708 part b
Hi Martin,
> Martin Fuzzey hat am 28. April 2015 um 16:17
> geschrieben:
>
>
> [...]
> diff --git a/drivers/regulator/mc34708-regulator.c
> b/drivers/regulator/mc34708-regulator.c
> new file mode 100644
> index 000..b5ff727
> --- /dev/null
> +++ b/drivers/regulator/mc34708-regulator.c
> @@ -0
On Tue, Apr 28, 2015 at 04:17:40PM +0200, Martin Fuzzey wrote:
> Signed-off-by: Martin Fuzzey
Please use subject lines reflecting the style for the subsystem.
> +static int mc34708_read_bits(struct mc34708_regulator *mc34708_reg,
> + unsigned int reg, u32 mask)
> +{
> +
Just a nit: a license mismatch.
On Tue, 2015-04-28 at 16:17 +0200, Martin Fuzzey wrote:
> --- /dev/null
> +++ b/drivers/regulator/mc34708-regulator.c
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * publ
Signed-off-by: Martin Fuzzey
---
drivers/regulator/Kconfig |7
drivers/regulator/Makefile|1
drivers/regulator/mc34708-regulator.c | 1266 +
3 files changed, 1274 insertions(+)
create mode 100644 drivers/regulator/mc34708-regulato
6 matches
Mail list logo
