Re: [PATCH 2/2] UBI: Block: Add blk-mq support

2015-01-10 Thread Richard Weinberger
Am 10.01.2015 um 19:58 schrieb Christoph Hellwig: >> +struct ubiblock_pdu { >> +struct request *req; > > No need to store the request, you can trivially get at it using > blk_mq_rq_from_pdu(). Very handy, I was not aware of blk_mq_rq_from_pdu(). >> +struct ubiblock *dev; > > Why do you

Re: [PATCH 2/2] UBI: Block: Add blk-mq support

2015-01-10 Thread Christoph Hellwig
> +struct ubiblock_pdu { > + struct request *req; No need to store the request, you can trivially get at it using blk_mq_rq_from_pdu(). > + struct ubiblock *dev; Why do you need the dev pointer? You can always trivially get it using req->queuedata. > +static void ubiblock_do_work(struc

[PATCH 2/2] UBI: Block: Add blk-mq support

2015-01-10 Thread Richard Weinberger
Convert the driver to blk-mq. Beside of moving to the modern block interface this change boosts also the performance of the driver. nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda nand: Micron NAND 256MiB 3,3V 8-bit nand: 256MiB, SLC, page size: 2048, OOB size: 64 root@debian-armhf:~# dd

[PATCH 2/2] UBI: Block: Add blk-mq support

2014-11-24 Thread Richard Weinberger
Convert the driver to blk-mq. Beside of moving to the modern block interface this change boosts also the performance of the driver. nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda nand: Micron NAND 256MiB 3,3V 8-bit nand: 256MiB, SLC, page size: 2048, OOB size: 64 root@debian-armhf:~# dd