Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Blaisorblade
On mercoledì 20 giugno 2007, Jeff Dike wrote: > On Wed, Jun 20, 2007 at 04:06:58PM +0200, Blaisorblade wrote: > > Oh, it's exactly what CONFIG_DEBUG_STACK_USAGE does for i386... (not sure > > if you were still wondering...). > > Where? The only usage in i386 that I see is thread_info.h zeroing

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Jeff Dike
On Tue, Jun 19, 2007 at 01:14:41PM -0700, Andrew Morton wrote: > Oh well. Your new code should really be generic, utilising the > stack-page-zeroing which CONFIG_DEBUG_STACK_USAGE enables. There's nothing > UML-specific about it. > > low_water_lock and lowest_to_date should be static to

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Jeff Dike
On Tue, Jun 19, 2007 at 12:57:07PM -0700, Randy Dunlap wrote: > Kconfig help text is indented 2 more spaces (by convention or > CodingStyle). OK, will fix. > > + if(*p != 0) > > if (*p != NULL) p is int *, so that's a int version pointer comparision. > or >

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Jeff Dike
On Wed, Jun 20, 2007 at 04:18:56PM +0200, Blaisorblade wrote: > In Italy we say "habits are hard to die"... "Old habits are hard to kill" I'm working on it. > In the end: are you interested in this stuff? I'm busy right now but > can work to apply these changes after this thursday > (i.e.

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Jeff Dike
On Wed, Jun 20, 2007 at 04:06:58PM +0200, Blaisorblade wrote: > Oh, it's exactly what CONFIG_DEBUG_STACK_USAGE does for i386... (not sure if > you were still wondering...). Where? The only usage in i386 that I see is thread_info.h zeroing stacks as they are allocated.

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Blaisorblade
On martedì 19 giugno 2007, Andrew Morton wrote: > On Tue, 19 Jun 2007 14:42:45 -0400 > > Jeff Dike <[EMAIL PROTECTED]> wrote: > > Add a machanism to see how much of a kernel stack is used. This > > allocates zeroed stacks and sees where the lowest non-zero byte is on > > process exit. It keeps

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Blaisorblade
On martedì 19 giugno 2007, Andrew Morton wrote: > On Tue, 19 Jun 2007 15:50:03 -0400 > > Jeff Dike <[EMAIL PROTECTED]> wrote: > > On Tue, Jun 19, 2007 at 11:54:22AM -0700, Andrew Morton wrote: > > > On Tue, 19 Jun 2007 14:42:45 -0400 > > > > > > Jeff Dike <[EMAIL PROTECTED]> wrote: > > > > Add a

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Blaisorblade
On martedì 19 giugno 2007, Andrew Morton wrote: On Tue, 19 Jun 2007 15:50:03 -0400 Jeff Dike [EMAIL PROTECTED] wrote: On Tue, Jun 19, 2007 at 11:54:22AM -0700, Andrew Morton wrote: On Tue, 19 Jun 2007 14:42:45 -0400 Jeff Dike [EMAIL PROTECTED] wrote: Add a machanism to see how

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Blaisorblade
On martedì 19 giugno 2007, Andrew Morton wrote: On Tue, 19 Jun 2007 14:42:45 -0400 Jeff Dike [EMAIL PROTECTED] wrote: Add a machanism to see how much of a kernel stack is used. This allocates zeroed stacks and sees where the lowest non-zero byte is on process exit. It keeps track of the

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Jeff Dike
On Wed, Jun 20, 2007 at 04:06:58PM +0200, Blaisorblade wrote: Oh, it's exactly what CONFIG_DEBUG_STACK_USAGE does for i386... (not sure if you were still wondering...). Where? The only usage in i386 that I see is thread_info.h zeroing stacks as they are allocated.

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Jeff Dike
On Wed, Jun 20, 2007 at 04:18:56PM +0200, Blaisorblade wrote: In Italy we say habits are hard to die... Old habits are hard to kill I'm working on it. In the end: are you interested in this stuff? I'm busy right now but can work to apply these changes after this thursday (i.e. tomorrow).

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Jeff Dike
On Tue, Jun 19, 2007 at 12:57:07PM -0700, Randy Dunlap wrote: Kconfig help text is indented 2 more spaces (by convention or CodingStyle). OK, will fix. + if(*p != 0) if (*p != NULL) p is int *, so that's a int version pointer comparision. or if

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Jeff Dike
On Tue, Jun 19, 2007 at 01:14:41PM -0700, Andrew Morton wrote: Oh well. Your new code should really be generic, utilising the stack-page-zeroing which CONFIG_DEBUG_STACK_USAGE enables. There's nothing UML-specific about it. low_water_lock and lowest_to_date should be static to

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Blaisorblade
On mercoledì 20 giugno 2007, Jeff Dike wrote: On Wed, Jun 20, 2007 at 04:06:58PM +0200, Blaisorblade wrote: Oh, it's exactly what CONFIG_DEBUG_STACK_USAGE does for i386... (not sure if you were still wondering...). Where? The only usage in i386 that I see is thread_info.h zeroing stacks

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 15:50:03 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > On Tue, Jun 19, 2007 at 11:54:22AM -0700, Andrew Morton wrote: > > On Tue, 19 Jun 2007 14:42:45 -0400 > > Jeff Dike <[EMAIL PROTECTED]> wrote: > > > > > Add a machanism to see how much of a kernel stack is used. This > >

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Randy Dunlap
On Tue, 19 Jun 2007 15:50:03 -0400 Jeff Dike wrote: > Add a machanism to see how much of a kernel stack is used. This > allocates zeroed stacks and sees where the lowest non-zero byte is on > process exit. It keeps track of the lowest value and logs values as > they get lower. > >

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Jeff Dike
On Tue, Jun 19, 2007 at 11:54:22AM -0700, Andrew Morton wrote: > On Tue, 19 Jun 2007 14:42:45 -0400 > Jeff Dike <[EMAIL PROTECTED]> wrote: > > > Add a machanism to see how much of a kernel stack is used. This > > allocates zeroed stacks and sees where the lowest non-zero byte is on > > process

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 14:42:45 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > Add a machanism to see how much of a kernel stack is used. This > allocates zeroed stacks and sees where the lowest non-zero byte is on > process exit. It keeps track of the lowest value and logs values as > they get

[PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Jeff Dike
Add a machanism to see how much of a kernel stack is used. This allocates zeroed stacks and sees where the lowest non-zero byte is on process exit. It keeps track of the lowest value and logs values as they get lower. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/Kconfig.debug

[PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Jeff Dike
Add a machanism to see how much of a kernel stack is used. This allocates zeroed stacks and sees where the lowest non-zero byte is on process exit. It keeps track of the lowest value and logs values as they get lower. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/Kconfig.debug|

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 14:42:45 -0400 Jeff Dike [EMAIL PROTECTED] wrote: Add a machanism to see how much of a kernel stack is used. This allocates zeroed stacks and sees where the lowest non-zero byte is on process exit. It keeps track of the lowest value and logs values as they get lower.

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Jeff Dike
On Tue, Jun 19, 2007 at 11:54:22AM -0700, Andrew Morton wrote: On Tue, 19 Jun 2007 14:42:45 -0400 Jeff Dike [EMAIL PROTECTED] wrote: Add a machanism to see how much of a kernel stack is used. This allocates zeroed stacks and sees where the lowest non-zero byte is on process exit. It

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Randy Dunlap
On Tue, 19 Jun 2007 15:50:03 -0400 Jeff Dike wrote: Add a machanism to see how much of a kernel stack is used. This allocates zeroed stacks and sees where the lowest non-zero byte is on process exit. It keeps track of the lowest value and logs values as they get lower. Signed-off-by:

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 15:50:03 -0400 Jeff Dike [EMAIL PROTECTED] wrote: On Tue, Jun 19, 2007 at 11:54:22AM -0700, Andrew Morton wrote: On Tue, 19 Jun 2007 14:42:45 -0400 Jeff Dike [EMAIL PROTECTED] wrote: Add a machanism to see how much of a kernel stack is used. This allocates