Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-02-01 Thread Yinghai Lu
On Fri, Feb 1, 2013 at 12:50 AM, Yijing Wang wrote: > On 2013/1/31 23:59, Yinghai Lu wrote: >> On Thu, Jan 31, 2013 at 7:37 AM, Jiang Liu wrote: >>> >>> So I think the code in handle_hotplug_event_bridge() to handle P2P >>> hot-addition >>> is dead. Yijing has helped to test the code by faking

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-02-01 Thread Bjorn Helgaas
On Wed, Jan 30, 2013 at 9:10 AM, Jiang Liu wrote: > From: Jiang Liu > > Commit 668192b678201d2fff27c "PCI: acpiphp: Move host bridge hotplug > to pci_root.c" has moved PCI host bridge hotplug logic from acpiphp > to pci_root, but there is still PCI host bridge hotplug related > dead code left in

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-02-01 Thread Yijing Wang
On 2013/1/31 23:59, Yinghai Lu wrote: > On Thu, Jan 31, 2013 at 7:37 AM, Jiang Liu wrote: >> >> So I think the code in handle_hotplug_event_bridge() to handle P2P >> hot-addition >> is dead. Yijing has helped to test the code by faking ACPI CUSTOM_METHOD, >> and it >> does work as expected. >

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-02-01 Thread Yijing Wang
On 2013/1/31 23:59, Yinghai Lu wrote: On Thu, Jan 31, 2013 at 7:37 AM, Jiang Liu liu...@gmail.com wrote: So I think the code in handle_hotplug_event_bridge() to handle P2P hot-addition is dead. Yijing has helped to test the code by faking ACPI CUSTOM_METHOD, and it does work as expected.

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-02-01 Thread Bjorn Helgaas
On Wed, Jan 30, 2013 at 9:10 AM, Jiang Liu liu...@gmail.com wrote: From: Jiang Liu jiang@huawei.com Commit 668192b678201d2fff27c PCI: acpiphp: Move host bridge hotplug to pci_root.c has moved PCI host bridge hotplug logic from acpiphp to pci_root, but there is still PCI host bridge

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-02-01 Thread Yinghai Lu
On Fri, Feb 1, 2013 at 12:50 AM, Yijing Wang wangyij...@huawei.com wrote: On 2013/1/31 23:59, Yinghai Lu wrote: On Thu, Jan 31, 2013 at 7:37 AM, Jiang Liu liu...@gmail.com wrote: So I think the code in handle_hotplug_event_bridge() to handle P2P hot-addition is dead. Yijing has helped to

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-01-31 Thread Yinghai Lu
On Thu, Jan 31, 2013 at 7:37 AM, Jiang Liu wrote: > > So I think the code in handle_hotplug_event_bridge() to handle P2P > hot-addition > is dead. Yijing has helped to test the code by faking ACPI CUSTOM_METHOD, and > it > does work as expected. ok, then. It would be better if you can append

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-01-31 Thread Jiang Liu
On 01/31/2013 01:27 AM, Yinghai Lu wrote: > On Wed, Jan 30, 2013 at 8:10 AM, Jiang Liu wrote: >> From: Jiang Liu >> >> Commit 668192b678201d2fff27c "PCI: acpiphp: Move host bridge hotplug >> to pci_root.c" has moved PCI host bridge hotplug logic from acpiphp >> to pci_root, but there is still

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-01-31 Thread Jiang Liu
On 01/31/2013 01:27 AM, Yinghai Lu wrote: On Wed, Jan 30, 2013 at 8:10 AM, Jiang Liu liu...@gmail.com wrote: From: Jiang Liu jiang@huawei.com Commit 668192b678201d2fff27c PCI: acpiphp: Move host bridge hotplug to pci_root.c has moved PCI host bridge hotplug logic from acpiphp to

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-01-31 Thread Yinghai Lu
On Thu, Jan 31, 2013 at 7:37 AM, Jiang Liu liu...@gmail.com wrote: So I think the code in handle_hotplug_event_bridge() to handle P2P hot-addition is dead. Yijing has helped to test the code by faking ACPI CUSTOM_METHOD, and it does work as expected. ok, then. It would be better if you

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-01-30 Thread Yinghai Lu
On Wed, Jan 30, 2013 at 8:10 AM, Jiang Liu wrote: > From: Jiang Liu > > Commit 668192b678201d2fff27c "PCI: acpiphp: Move host bridge hotplug > to pci_root.c" has moved PCI host bridge hotplug logic from acpiphp > to pci_root, but there is still PCI host bridge hotplug related > dead code left in

[PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-01-30 Thread Jiang Liu
From: Jiang Liu Commit 668192b678201d2fff27c "PCI: acpiphp: Move host bridge hotplug to pci_root.c" has moved PCI host bridge hotplug logic from acpiphp to pci_root, but there is still PCI host bridge hotplug related dead code left in acpiphp. So remove those dead code. Now companion ACPI

[PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-01-30 Thread Jiang Liu
From: Jiang Liu jiang@huawei.com Commit 668192b678201d2fff27c PCI: acpiphp: Move host bridge hotplug to pci_root.c has moved PCI host bridge hotplug logic from acpiphp to pci_root, but there is still PCI host bridge hotplug related dead code left in acpiphp. So remove those dead code. Now

Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug

2013-01-30 Thread Yinghai Lu
On Wed, Jan 30, 2013 at 8:10 AM, Jiang Liu liu...@gmail.com wrote: From: Jiang Liu jiang@huawei.com Commit 668192b678201d2fff27c PCI: acpiphp: Move host bridge hotplug to pci_root.c has moved PCI host bridge hotplug logic from acpiphp to pci_root, but there is still PCI host bridge