Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-10-21 Thread Konrad Dybcio
On 10/21/23 16:30, Lukas Walter wrote: This dts adds support for Huawei Honor 5X / GR5 (2016) smartphone released in 2015. Add device tree with initial support for: - GPIO keys - Hall sensor - SDHCI (internal and external storage) - WCNSS (BT/WIFI) - Sensors (accelerometer and proximity) -

[PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-10-21 Thread Lukas Walter
This dts adds support for Huawei Honor 5X / GR5 (2016) smartphone released in 2015. Add device tree with initial support for: - GPIO keys - Hall sensor - SDHCI (internal and external storage) - WCNSS (BT/WIFI) - Sensors (accelerometer and proximity) - Vibrator - Touchscreen Signed-off-by:

Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-10-05 Thread lukas walter
>> Is this fine? >> Should I send a V2 with the signoff and reserved-memory changes? >I don't quite get it, what signoff? Krzysztof noticed that the Signed-off-by are in the wrong order. But I was told this alone is not worth a V2.

Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-09-25 Thread Konrad Dybcio
On 25.09.2023 16:28, lukas walter wrote: > Date: Wed, 20 Sep 2023 16:47:30 +0200 > >>> + >>> + reserved-memory { >>> + reserved@84a0 { >>> + reg = <0x0 0x84a0 0x0 0x160>; >>> + no-map; >>> + }; >> Do we know what this is for? >

Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-09-25 Thread lukas walter
Date: Wed, 20 Sep 2023 16:47:30 +0200 >> + >> +reserved-memory { >> +reserved@84a0 { >> +reg = <0x0 0x84a0 0x0 0x160>; >> +no-map; >> +}; >Do we know what this is for? This seems to be some QSEE/TrustZone memory

Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-09-20 Thread Konrad Dybcio
On 9/16/23 15:41, Lukas Walter wrote: This dts adds support for Huawei Honor 5X / GR5 (2016) smartphone released in 2015. Add device tree with initial support for: - GPIO keys - Hall sensor - SDHCI (internal and external storage) - WCNSS (BT/WIFI) - Sensors (accelerometer, proximity and

Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-09-17 Thread lukas walter
>Are you sure this is 3620, have you tried wcn3660 and/or wcn3680 ? I am sure. Downstream source [1] and downstream dmesg (wcnss: IRIS Reg: 51120004 which should equal [2]) indicate 3620 (3620A does not exist) [1]:

Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-09-17 Thread lukas walter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >Order of SoB is unusual. Who did what here? I created the dts and they update the model name. So it should be the other way around -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEEi1ngOOsyNO1iyMXiY16HCsLx2zUFAmUG/FQACgkQY16HCsLx

Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-09-16 Thread Bryan O'Donoghue
On 16/09/2023 14:41, Lukas Walter wrote: + +_iris { + compatible = "qcom,wcn3620"; +}; + Are you sure this is 3620, have you tried wcn3660 and/or wcn3680 ? --- bod

Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-09-16 Thread Krzysztof Kozlowski
On 16/09/2023 15:41, Lukas Walter wrote: > This dts adds support for Huawei Honor 5X / GR5 (2016) smartphone > released in 2015. > > Add device tree with initial support for: > > - GPIO keys > - Hall sensor > - SDHCI (internal and external storage) > - WCNSS (BT/WIFI) > - Sensors (accelerometer,

[PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-09-16 Thread Lukas Walter
This dts adds support for Huawei Honor 5X / GR5 (2016) smartphone released in 2015. Add device tree with initial support for: - GPIO keys - Hall sensor - SDHCI (internal and external storage) - WCNSS (BT/WIFI) - Sensors (accelerometer, proximity and gyroscope) - Vibrator - Touchscreen