Re: [PATCH 2/2] blk-iocost: Use alloc_percpu_gfp() to simplify the code

2020-12-16 Thread Baolin Wang
Hi Tejun, Hello, On Fri, Dec 11, 2020 at 03:13:29PM +0800, Baolin Wang wrote: Thanks for teaching me this, at least I did not get this from the local_ops Documentation before. Just out of curiosity, these local[64]_t variables are also allocated from budy allocator ultimately, why they can not

Re: [PATCH 2/2] blk-iocost: Use alloc_percpu_gfp() to simplify the code

2020-12-16 Thread Tejun Heo
Hello, On Fri, Dec 11, 2020 at 03:13:29PM +0800, Baolin Wang wrote: > Thanks for teaching me this, at least I did not get this from the local_ops > Documentation before. Just out of curiosity, these local[64]_t variables are > also allocated from budy allocator ultimately, why they can not be > in

Re: [PATCH 2/2] blk-iocost: Use alloc_percpu_gfp() to simplify the code

2020-12-10 Thread Baolin Wang
Hi Tejun, Hello, On Thu, Dec 10, 2020 at 06:56:45PM +0800, Baolin Wang wrote: Use alloc_percpu_gfp() with __GFP_ZERO flag, which can remove some explicit initialization code. __GFP_ZERO is implicit for percpu allocations and local[64]_t's initial states aren't guaranteed to be all zeros on d

Re: [PATCH 2/2] blk-iocost: Use alloc_percpu_gfp() to simplify the code

2020-12-10 Thread Tejun Heo
Hello, On Thu, Dec 10, 2020 at 06:56:45PM +0800, Baolin Wang wrote: > Use alloc_percpu_gfp() with __GFP_ZERO flag, which can remove > some explicit initialization code. __GFP_ZERO is implicit for percpu allocations and local[64]_t's initial states aren't guaranteed to be all zeros on different ar

[PATCH 2/2] blk-iocost: Use alloc_percpu_gfp() to simplify the code

2020-12-10 Thread Baolin Wang
Use alloc_percpu_gfp() with __GFP_ZERO flag, which can remove some explicit initialization code. Signed-off-by: Baolin Wang --- block/blk-iocost.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/block/blk-iocost.c b/block/blk-iocost.c index ac6078a..52ce2e3 1