Re: [PATCH 2/2] block: remove retry loop in ioc_release_fn()

2020-06-23 Thread Daniel Wagner
On Fri, Jun 19, 2020 at 05:23:18PM +0206, John Ogness wrote: > The reverse-order double lock dance in ioc_release_fn() is using a > retry loop. This is a problem on PREEMPT_RT because it could preempt > the task that would release q->queue_lock and thus live lock in the > retry loop. > > RCU is

[PATCH 2/2] block: remove retry loop in ioc_release_fn()

2020-06-19 Thread John Ogness
The reverse-order double lock dance in ioc_release_fn() is using a retry loop. This is a problem on PREEMPT_RT because it could preempt the task that would release q->queue_lock and thus live lock in the retry loop. RCU is already managing the freeing of the request queue and icq. If the trylock