On Tue, Jan 08, 2013 at 02:28:44PM +0800, Li Zefan wrote:
> > cgroups: fix cgroup_event_listener error handling
> >
> > The error handling in cgroup_event_listener.c did not correctly deal
> > with either an error opening either or
> > cgroup.event_control. Due to an uninitialized variable the
On Tue, Jan 08, 2013 at 02:28:44PM +0800, Li Zefan wrote:
cgroups: fix cgroup_event_listener error handling
The error handling in cgroup_event_listener.c did not correctly deal
with either an error opening either control_file or
cgroup.event_control. Due to an uninitialized variable
> cgroups: fix cgroup_event_listener error handling
>
> The error handling in cgroup_event_listener.c did not correctly deal
> with either an error opening either or
> cgroup.event_control. Due to an uninitialized variable the program
> exit code was undefined if either of these opens failed.
>
On Mon, Jan 07 2013, Tejun Heo wrote:
> On Fri, Jan 04, 2013 at 01:05:18PM -0800, Greg Thelen wrote:
>> If the command line parameter cannot
>> be opened, then cgroup_event_listener prints an error message and
>> tries to return an error. However, due to an uninitialized variable
>> the return
On Fri, Jan 04, 2013 at 01:05:18PM -0800, Greg Thelen wrote:
> If the command line parameter cannot
> be opened, then cgroup_event_listener prints an error message and
> tries to return an error. However, due to an uninitialized variable
> the return value was undefined.
>
> With this patch
On Fri, Jan 04, 2013 at 01:05:18PM -0800, Greg Thelen wrote:
If the absolute-path-to-control-file command line parameter cannot
be opened, then cgroup_event_listener prints an error message and
tries to return an error. However, due to an uninitialized variable
the return value was undefined.
On Mon, Jan 07 2013, Tejun Heo wrote:
On Fri, Jan 04, 2013 at 01:05:18PM -0800, Greg Thelen wrote:
If the absolute-path-to-control-file command line parameter cannot
be opened, then cgroup_event_listener prints an error message and
tries to return an error. However, due to an uninitialized
cgroups: fix cgroup_event_listener error handling
The error handling in cgroup_event_listener.c did not correctly deal
with either an error opening either control_file or
cgroup.event_control. Due to an uninitialized variable the program
exit code was undefined if either of these opens
If the command line parameter cannot
be opened, then cgroup_event_listener prints an error message and
tries to return an error. However, due to an uninitialized variable
the return value was undefined.
With this patch such failures always return non-zero error.
Compiler warning found this:
If the absolute-path-to-control-file command line parameter cannot
be opened, then cgroup_event_listener prints an error message and
tries to return an error. However, due to an uninitialized variable
the return value was undefined.
With this patch such failures always return non-zero error.
10 matches
Mail list logo