Re: [PATCH 2/2] cpufreq: governors: remove redundant code

2012-11-23 Thread Fabio Baltieri
Hello Viresh, On Sat, Oct 20, 2012 at 01:42:06AM +0530, Viresh Kumar wrote: > +static inline int delay_for_sampling_rate(unsigned int sampling_rate) > +{ > + int delay = usecs_to_jiffies(sampling_rate); > + > + /* We want all CPUs to do sampling nearly on same jiffy */ > + if (num_onli

Re: [PATCH 2/2] cpufreq: governors: remove redundant code

2012-10-25 Thread Viresh Kumar
On 26 October 2012 05:43, Rafael J. Wysocki wrote: > I have applied this patch only because of the fixes on top of it. It broke > kernel compliation due to some missing EXPORT_SYMBOL_GPLs in > cpufreq_governor.c, > so I woulnd't have applied it otherwise. Hi Rafael, So sorry for this. I am re

Re: [PATCH 2/2] cpufreq: governors: remove redundant code

2012-10-25 Thread Rafael J. Wysocki
On Thursday, October 25, 2012 08:59:11 AM Viresh Kumar wrote: > On 25 October 2012 02:42, Rafael J. Wysocki wrote: > > On Wednesday 24 of October 2012 21:43:46 Rafael J. Wysocki wrote: > >> On Wednesday 24 of October 2012 11:37:13 Viresh Kumar wrote: > >> > On 22 October 2012 14:16, Viresh Kumar

Re: [PATCH 2/2] cpufreq: governors: remove redundant code

2012-10-24 Thread Rafael J. Wysocki
On Wednesday 24 of October 2012 21:43:46 Rafael J. Wysocki wrote: > On Wednesday 24 of October 2012 11:37:13 Viresh Kumar wrote: > > On 22 October 2012 14:16, Viresh Kumar wrote: > > > On 20 October 2012 01:42, Viresh Kumar wrote: > > >> Initially ondemand governor was written and then using its

Re: [PATCH 2/2] cpufreq: governors: remove redundant code

2012-10-24 Thread Rafael J. Wysocki
On Wednesday 24 of October 2012 11:37:13 Viresh Kumar wrote: > On 22 October 2012 14:16, Viresh Kumar wrote: > > On 20 October 2012 01:42, Viresh Kumar wrote: > >> Initially ondemand governor was written and then using its code > >> conservative > >> governor is written. It used a lot of code fr

Re: [PATCH 2/2] cpufreq: governors: remove redundant code

2012-10-23 Thread Viresh Kumar
On 22 October 2012 14:16, Viresh Kumar wrote: > On 20 October 2012 01:42, Viresh Kumar wrote: >> Initially ondemand governor was written and then using its code conservative >> governor is written. It used a lot of code from ondemand governor, but copy >> of >> code was created instead of using

Re: [PATCH 2/2] cpufreq: governors: remove redundant code

2012-10-22 Thread Viresh Kumar
On 20 October 2012 01:42, Viresh Kumar wrote: > Initially ondemand governor was written and then using its code conservative > governor is written. It used a lot of code from ondemand governor, but copy of > code was created instead of using the same routines from both governors. Which > increased