Re: [PATCH 2/2] cpuidle: fix sysfs output for power_usage

2012-12-17 Thread Rafael J. Wysocki
On Monday, December 17, 2012 10:46:07 AM Sivaram Nair wrote: > On Mon, Dec 17, 2012 at 08:56:45AM +0100, Rafael J. Wysocki wrote: > > On Monday, December 17, 2012 09:38:15 AM Sivaram Nair wrote: > > > On Sat, Dec 15, 2012 at 01:03:02AM +0100, Rafael J. Wysocki wrote: > > > > On Friday, December 14,

Re: [PATCH 2/2] cpuidle: fix sysfs output for power_usage

2012-12-17 Thread Sivaram Nair
On Mon, Dec 17, 2012 at 08:56:45AM +0100, Rafael J. Wysocki wrote: > On Monday, December 17, 2012 09:38:15 AM Sivaram Nair wrote: > > On Sat, Dec 15, 2012 at 01:03:02AM +0100, Rafael J. Wysocki wrote: > > > On Friday, December 14, 2012 03:17:37 PM Sivaram Nair wrote: > > > > cpuidle_state->power_us

Re: [PATCH 2/2] cpuidle: fix sysfs output for power_usage

2012-12-16 Thread Rafael J. Wysocki
On Monday, December 17, 2012 09:38:15 AM Sivaram Nair wrote: > On Sat, Dec 15, 2012 at 01:03:02AM +0100, Rafael J. Wysocki wrote: > > On Friday, December 14, 2012 03:17:37 PM Sivaram Nair wrote: > > > cpuidle_state->power_usage is signed; so change the corresponding sysfs > > > ops to output signed

Re: [PATCH 2/2] cpuidle: fix sysfs output for power_usage

2012-12-16 Thread Sivaram Nair
On Sat, Dec 15, 2012 at 01:03:02AM +0100, Rafael J. Wysocki wrote: > On Friday, December 14, 2012 03:17:37 PM Sivaram Nair wrote: > > cpuidle_state->power_usage is signed; so change the corresponding sysfs > > ops to output signed value instead of unsigned. > > What's actually wrong with printing

Re: [PATCH 2/2] cpuidle: fix sysfs output for power_usage

2012-12-14 Thread Rafael J. Wysocki
On Friday, December 14, 2012 03:17:37 PM Sivaram Nair wrote: > cpuidle_state->power_usage is signed; so change the corresponding sysfs > ops to output signed value instead of unsigned. What's actually wrong with printing it as an unsigned int? Rafael > Signed-off-by: Sivaram Nair > --- > driv

[PATCH 2/2] cpuidle: fix sysfs output for power_usage

2012-12-14 Thread Sivaram Nair
cpuidle_state->power_usage is signed; so change the corresponding sysfs ops to output signed value instead of unsigned. Signed-off-by: Sivaram Nair --- drivers/cpuidle/sysfs.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle