On Mon, Aug 17, 2015 at 06:05:04PM -0700, Tadeusz Struk wrote:
> On 08/17/2015 01:50 AM, Herbert Xu wrote:
> >> If you don't like the first option then we still need this, as you pointed
> >> out.
> > Yes this looks like the right fix for qat. Please add a sign-off.
> > You might be able to just
On 08/17/2015 01:50 AM, Herbert Xu wrote:
>> If you don't like the first option then we still need this, as you pointed
>> out.
> Yes this looks like the right fix for qat. Please add a sign-off.
> You might be able to just do it by replying to this thread, and
> patchwork may be able to pick it
On Fri, Aug 14, 2015 at 07:24:23AM -0700, Tadeusz Struk wrote:
>
> If you don't like the first option then we still need this, as you pointed
> out.
Yes this looks like the right fix for qat. Please add a sign-off.
You might be able to just do it by replying to this thread, and
patchwork may be
On Fri, Aug 14, 2015 at 07:21:29AM -0700, Tadeusz Struk wrote:
>
> Yes, that was wrong, sorry. The reason I wanted to change it is that
> the SW implementation can return a number with leading zeros.
> This is because mpi_read_buffer() returns the whole thing.
I think mpi_read_buffer is broken.
On Mon, Aug 17, 2015 at 06:05:04PM -0700, Tadeusz Struk wrote:
On 08/17/2015 01:50 AM, Herbert Xu wrote:
If you don't like the first option then we still need this, as you pointed
out.
Yes this looks like the right fix for qat. Please add a sign-off.
You might be able to just do it by
On 08/17/2015 01:50 AM, Herbert Xu wrote:
If you don't like the first option then we still need this, as you pointed
out.
Yes this looks like the right fix for qat. Please add a sign-off.
You might be able to just do it by replying to this thread, and
patchwork may be able to pick it up and
On Fri, Aug 14, 2015 at 07:24:23AM -0700, Tadeusz Struk wrote:
If you don't like the first option then we still need this, as you pointed
out.
Yes this looks like the right fix for qat. Please add a sign-off.
You might be able to just do it by replying to this thread, and
patchwork may be
On Fri, Aug 14, 2015 at 07:21:29AM -0700, Tadeusz Struk wrote:
Yes, that was wrong, sorry. The reason I wanted to change it is that
the SW implementation can return a number with leading zeros.
This is because mpi_read_buffer() returns the whole thing.
I think mpi_read_buffer is broken. It
On 08/13/2015 11:26 PM, Herbert Xu wrote:
> On Thu, Aug 13, 2015 at 11:14:11PM -0700, Tadeusz Struk wrote:
>>
>> Right, but we don't need that anymore.
>
> Why not? If you reduce the size without moving the buffer wouldn't
> it begin with a bunch of zeroes and wouldn't you lose the real bytes
>
Hi Herbert,
On 08/13/2015 11:26 PM, Herbert Xu wrote:
> On Thu, Aug 13, 2015 at 11:14:11PM -0700, Tadeusz Struk wrote:
>>
>> Right, but we don't need that anymore.
>
> Why not? If you reduce the size without moving the buffer wouldn't
> it begin with a bunch of zeroes and wouldn't you lose the
On Thu, Aug 13, 2015 at 11:14:11PM -0700, Tadeusz Struk wrote:
>
> Right, but we don't need that anymore.
Why not? If you reduce the size without moving the buffer wouldn't
it begin with a bunch of zeroes and wouldn't you lose the real bytes
at the end?
Cheers,
--
Email: Herbert Xu
Home Page:
On 08/13/2015 10:14 PM, Herbert Xu wrote:
>> diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c
>> b/drivers/crypto/qat/qat_common/qat_asym_algs.c
>> > index fe352a6..6ddb13c 100644
>> > --- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
>> > +++
On Thu, Aug 13, 2015 at 11:14:11PM -0700, Tadeusz Struk wrote:
Right, but we don't need that anymore.
Why not? If you reduce the size without moving the buffer wouldn't
it begin with a bunch of zeroes and wouldn't you lose the real bytes
at the end?
Cheers,
--
Email: Herbert Xu
On 08/13/2015 10:14 PM, Herbert Xu wrote:
diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c
b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index fe352a6..6ddb13c 100644
--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
@@
Hi Herbert,
On 08/13/2015 11:26 PM, Herbert Xu wrote:
On Thu, Aug 13, 2015 at 11:14:11PM -0700, Tadeusz Struk wrote:
Right, but we don't need that anymore.
Why not? If you reduce the size without moving the buffer wouldn't
it begin with a bunch of zeroes and wouldn't you lose the real bytes
On 08/13/2015 11:26 PM, Herbert Xu wrote:
On Thu, Aug 13, 2015 at 11:14:11PM -0700, Tadeusz Struk wrote:
Right, but we don't need that anymore.
Why not? If you reduce the size without moving the buffer wouldn't
it begin with a bunch of zeroes and wouldn't you lose the real bytes
at the
On Wed, Aug 12, 2015 at 08:54:45PM -0700, Tadeusz Struk wrote:
> Don't need to move data inside of the output buffer
> because SW doen't need to do this anymore sice the new MPI
> mpi_read_buf() has been added. Just set the correct output len.
>
> Signed-off-by: Tadeusz Struk
> ---
>
On 08/12/2015 08:54 PM, Tadeusz Struk wrote:
> Don't need to move data inside of the output buffer
> because SW doen't need to do this anymore sice the new MPI
> mpi_read_buf() has been added. Just set the correct output len.
>
> Signed-off-by: Tadeusz Struk
> ---
>
On 08/12/2015 08:54 PM, Tadeusz Struk wrote:
Don't need to move data inside of the output buffer
because SW doen't need to do this anymore sice the new MPI
mpi_read_buf() has been added. Just set the correct output len.
Signed-off-by: Tadeusz Struk tadeusz.st...@intel.com
---
On Wed, Aug 12, 2015 at 08:54:45PM -0700, Tadeusz Struk wrote:
Don't need to move data inside of the output buffer
because SW doen't need to do this anymore sice the new MPI
mpi_read_buf() has been added. Just set the correct output len.
Signed-off-by: Tadeusz Struk tadeusz.st...@intel.com
Don't need to move data inside of the output buffer
because SW doen't need to do this anymore sice the new MPI
mpi_read_buf() has been added. Just set the correct output len.
Signed-off-by: Tadeusz Struk
---
drivers/crypto/qat/qat_common/qat_asym_algs.c |3 ---
1 file changed, 3
Don't need to move data inside of the output buffer
because SW doen't need to do this anymore sice the new MPI
mpi_read_buf() has been added. Just set the correct output len.
Signed-off-by: Tadeusz Struk tadeusz.st...@intel.com
---
drivers/crypto/qat/qat_common/qat_asym_algs.c |3 ---
1 file
22 matches
Mail list logo
