Re: [PATCH 2/2] devfreq: Rename df->previous_freq to df->cur_freq

2019-09-26 Thread Matthias Kaehlcke
On Thu, Sep 26, 2019 at 10:41:24AM +0900, Chanwoo Choi wrote: > Hi, > > I'm not objecting this patch. > But, as I commented on previous patch, > Actually, according to reference time of the 'df->previous_freq', > 'previous_freq' is proper or 'cur_freq is proper. > But, In the comment of 'struct de

Re: [PATCH 2/2] devfreq: Rename df->previous_freq to df->cur_freq

2019-09-25 Thread Chanwoo Choi
Hi, I'm not objecting this patch. But, as I commented on previous patch, Actually, according to reference time of the 'df->previous_freq', 'previous_freq' is proper or 'cur_freq is proper. But, In the comment of 'struct devfreq', it means the configured time as following: It was the intention of a

[PATCH 2/2] devfreq: Rename df->previous_freq to df->cur_freq

2019-09-25 Thread Matthias Kaehlcke
The vast majority of code uses df->previous_freq to get the current frequency of the devfreq device, not the previous one. Rename the struct field to reflect this. Add a comment to devfreq_update_stats() to make clear that df->cur_freq must only be updated after calling this function in the contex